-
Notifications
You must be signed in to change notification settings - Fork 135
Fixing labeler again #1343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing labeler again #1343
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to add the following, just in case.
If that doesn't work, we can always use the demo worklows. |
Codecov Report
@@ Coverage Diff @@
## main #1343 +/- ##
=======================================
Coverage 75.91% 75.91%
=======================================
Files 43 43
Lines 6813 6813
=======================================
Hits 5172 5172
Misses 1641 1641 |
Please add one of the following labels to add this contribution to the Release Notes 👇 |
It is working now 😄 |
yep! I'm lucky sometimes. But I think it should not comment if the bot add some labels |
This
is not working fine. |
Pinging @PProfizi for keeping him on the loop. Also @RobPasMue because surely he can add something to this and probably he is looking for some fun stuff. xD |
I can't believe it took 5 runs before I got all the tests to pass (I guess Github is not very stable lastly). |
Any ideas on this:
|
I've heard this is kind of an ugly hack but... It may work. So, we could set up an of condition for the commenter similar to this code block https://github.com/orgs/community/discussions/27125#discussioncomment-3254718 |
In case there already labels --> Avoid commenting. Targeting specific bot actions is going to be more difficult I guess... |
I've seen this as well. The issue isn't GH, it's anything that requires IO is much less forgiving in regards to buffers and caching. I've seen similar issues with race conditions on pyvista. It's just a sign we need to fix MAPDL having to write to disk for each and every command (unless muted). |
What about this? https://github.com/orgs/community/discussions/27125#discussioncomment-3254720 |
I'm just going to merge, so I can test this is working. |
Testing:
Both works.... Green light 🟢 |
* Trying... * Update. * adding labels file * check if existing labels improvement
* Trying... * Update. * adding labels file * check if existing labels improvement
This thing breaks way too much in my opinion.
But finally, it should close #1337.