Skip to content

Fixing labeler again #1343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 22, 2022
Merged

Fixing labeler again #1343

merged 4 commits into from
Aug 22, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Aug 10, 2022

This thing breaks way too much in my opinion.

But finally, it should close #1337.

Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to add the following, just in case.

@jorgepiloto
Copy link
Member

If that doesn't work, we can always use the demo worklows.

@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #1343 (12e02e5) into main (efc02a9) will not change coverage.
The diff coverage is n/a.

❗ Current head 12e02e5 differs from pull request most recent head 9bb254d. Consider uploading reports for the commit 9bb254d to get more accurate results

@@           Coverage Diff           @@
##             main    #1343   +/-   ##
=======================================
  Coverage   75.91%   75.91%           
=======================================
  Files          43       43           
  Lines        6813     6813           
=======================================
  Hits         5172     5172           
  Misses       1641     1641           

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc Maintenance labels Aug 10, 2022
@github-actions
Copy link
Contributor

Please add one of the following labels to add this contribution to the Release Notes 👇

@jorgepiloto
Copy link
Member

It is working now 😄

@germa89
Copy link
Collaborator Author

germa89 commented Aug 10, 2022

yep! I'm lucky sometimes.

But I think it should not comment if the bot add some labels

@germa89
Copy link
Collaborator Author

germa89 commented Aug 10, 2022

This if:

if: toJSON(github.event.pull_request.labels.*.name) == '[]'

is not working fine.

@germa89
Copy link
Collaborator Author

germa89 commented Aug 10, 2022

Pinging @PProfizi for keeping him on the loop.

Also @RobPasMue because surely he can add something to this and probably he is looking for some fun stuff. xD

@germa89 germa89 changed the title Fix/fixing labeler Fixing labeler again Aug 10, 2022
@germa89
Copy link
Collaborator Author

germa89 commented Aug 11, 2022

I can't believe it took 5 runs before I got all the tests to pass (I guess Github is not very stable lastly).

@germa89
Copy link
Collaborator Author

germa89 commented Aug 11, 2022

Any ideas on this:

But I think it should not comment if the bot add some labels

@jorgepiloto @RobPasMue

@RobPasMue
Copy link
Member

I've heard this is kind of an ugly hack but... It may work. So, we could set up an of condition for the commenter similar to this code block https://github.com/orgs/community/discussions/27125#discussioncomment-3254718

@RobPasMue
Copy link
Member

In case there already labels --> Avoid commenting.

Targeting specific bot actions is going to be more difficult I guess...

@akaszynski
Copy link
Collaborator

I can't believe it took 5 runs before I got all the tests to pass (I guess Github is not very stable lastly).

I've seen this as well. The issue isn't GH, it's anything that requires IO is much less forgiving in regards to buffers and caching. I've seen similar issues with race conditions on pyvista. It's just a sign we need to fix MAPDL having to write to disk for each and every command (unless muted).

@germa89 germa89 requested a review from jorgepiloto August 22, 2022 14:36
@germa89
Copy link
Collaborator Author

germa89 commented Aug 22, 2022

I've heard this is kind of an ugly hack but... It may work. So, we could set up an of condition for the commenter similar to this code block https://github.com/orgs/community/discussions/27125#discussioncomment-3254718

What about this?

https://github.com/orgs/community/discussions/27125#discussioncomment-3254720

@germa89
Copy link
Collaborator Author

germa89 commented Aug 22, 2022

I'm just going to merge, so I can test this is working.

@germa89 germa89 enabled auto-merge (squash) August 22, 2022 14:43
@germa89 germa89 disabled auto-merge August 22, 2022 14:57
@germa89 germa89 merged commit 9d68c32 into main Aug 22, 2022
@germa89 germa89 deleted the fix/fixing-labeler branch August 22, 2022 14:57
@germa89
Copy link
Collaborator Author

germa89 commented Aug 22, 2022

Testing:

  • No manual label, no significant files/directories changes. Expected: Bot comment.
    testasdfasdf #1381 🆗

  • No manual label. Changing marked file. Expected: Bot labeling but not commenting.
    myasdftest2 #1382 🆗

Both works.... Green light 🟢

@germa89 germa89 mentioned this pull request Aug 22, 2022
@germa89 germa89 added this to the v0.63.2 milestone Aug 31, 2022
germa89 added a commit that referenced this pull request Sep 1, 2022
* Trying...

* Update.

* adding labels file

* check if existing labels improvement
germa89 added a commit that referenced this pull request Sep 1, 2022
germa89 added a commit that referenced this pull request Sep 1, 2022
* Trying...

* Update.

* adding labels file

* check if existing labels improvement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Labeler hasnt been triggered lastly
4 participants