Skip to content

Add name, array parameters, @ operator to ApdlMath #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jun 1, 2022
Merged

Add name, array parameters, @ operator to ApdlMath #1149

merged 22 commits into from
Jun 1, 2022

Conversation

clatapie
Copy link
Contributor

Second attempt to add the name and array parameters and the @ operator.

@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #1149 (0d70b17) into main (263222d) will increase coverage by 0.05%.
The diff coverage is 94.87%.

❗ Current head 0d70b17 differs from pull request most recent head aee63c1. Consider uploading reports for the commit aee63c1 to get more accurate results

@@            Coverage Diff             @@
##             main    #1149      +/-   ##
==========================================
+ Coverage   77.97%   78.02%   +0.05%     
==========================================
  Files          43       43              
  Lines        6760     6777      +17     
==========================================
+ Hits         5271     5288      +17     
  Misses       1489     1489              

@akaszynski akaszynski changed the title Camille Add name, array parameters, @ operator to ApdlMath May 31, 2022
@clatapie clatapie requested review from FredAns and germa89 June 1, 2022 11:45
Copy link
Contributor

@FredAns FredAns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Camille, seems good to me.
Nice work !
Fred

@akaszynski
Copy link
Collaborator

akaszynski commented Jun 1, 2022

@clatapie, please use pre-commit to help you out with style changes. This way you know that when you push that it won't have any style issues. See: https://mapdldocs.pyansys.com/contributing.html#code-style

Also, in the future, please follow the branch naming conventions.

@akaszynski akaszynski merged commit 9dfa4c4 into main Jun 1, 2022
@akaszynski akaszynski deleted the Camille branch June 1, 2022 15:18
@clatapie
Copy link
Contributor Author

clatapie commented Jun 1, 2022

Hello @akaszynski , I'll make sure to use this command next time and to follow the branch naming conventions.
Thank you for your recommendations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants