Skip to content

Improved all Examples by adding reports #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 18, 2022
Merged

Conversation

maxcapodi78
Copy link
Collaborator

No description provided.

@maxcapodi78 maxcapodi78 requested a review from MaxJPRey March 18, 2022 11:26
@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #968 (74c1280) into main (efd119b) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #968      +/-   ##
==========================================
+ Coverage   80.63%   80.66%   +0.03%     
==========================================
  Files         128      128              
  Lines       38116    38127      +11     
==========================================
+ Hits        30734    30756      +22     
+ Misses       7382     7371      -11     

Copy link
Collaborator

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxcapodi78 Some files in the IronPython package are modified. They should not. It might come from black tool when pre-commit is performed. I thought those files were excluded. I will double check.

@MaxJPRey
Copy link
Collaborator

@maxcapodi78 Some files in the IronPython package are modified. They should not. It might come from black tool when pre-commit is performed. I thought those files were excluded. I will double check.

@maxcapodi78 I doubled check and the python files located under third-party are not affected by the pre-commit . We should not have any issue with that in the future. Here it might be due to our black formatting tool version conflict that we fixed couple days ago.

@maxcapodi78 maxcapodi78 merged commit 8595ff7 into main Mar 18, 2022
@maxcapodi78 maxcapodi78 deleted the enhance_examples_reports branch March 18, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants