Ignore project coverage #910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #910 +/- ##
==========================================
+ Coverage 80.13% 80.21% +0.08%
==========================================
Files 128 128
Lines 37365 37419 +54
==========================================
+ Hits 29941 30015 +74
+ Misses 7424 7404 -20 |
|
@akaszynski 90% for new code is good but on existing code is though to reach. I would use 85% for now and increase it as soon as the overall rate is around that percentage |
maxcapodi78
approved these changes
Mar 3, 2022
MaxJPRey
approved these changes
Mar 3, 2022
|
Don't merge quite yet. I'll be lowering to 85 and completely skipping the project check all together. |
|
@akaszynski Try to merge the main. We did lot of improvements on the unit tests. |
|
Finally working! Merging, thanks for the hint @Alberto-DM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems that even with #907, codecov doesn't like negative project coverage changes. This PR completely removes the project coverage CI reports and will only fail on patch < 90%.
@maxcapodi78, do you feel that 90% on new features is too high, or should be go lower than that?