Do not enforce global threshold #907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #907 +/- ##
==========================================
- Coverage 80.09% 80.09% -0.01%
==========================================
Files 128 128
Lines 36945 36945
==========================================
- Hits 29592 29591 -1
- Misses 7353 7354 +1 |
|
Make sense @akaszynski . LGTM. |
MaxJPRey
approved these changes
Mar 2, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recommend only enforcing patch coverage. There will be times when you remove source and come out with more efficient code by "lose" coverage. We should only worry about patch.
BTW, great job getting above 80%!