Skip to content

REFACTOR: Improve assign balloon method #6017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 9, 2025
Merged

REFACTOR: Improve assign balloon method #6017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a3f26d
REFACTOR: Improve assign balloon method
SMoraisAnsys Apr 7, 2025
cf52ff3
chore: adding changelog file 6017.miscellaneous.md [dependabot-skip]
pyansys-ci-bot Apr 7, 2025
fdf00b3
Update src/ansys/aedt/core/maxwell.py
SMoraisAnsys Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changelog.d/6017.miscellaneous.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Improve assign balloon method
7 changes: 4 additions & 3 deletions src/ansys/aedt/core/maxwell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3375,9 +3375,8 @@
Name of the boundary. The default is ``None``, in which
case the default name is used.
is_voltage: bool, optional
Balloon type. This option is valid for Electrostatic solvers only.
If ``True`` boundary type is "Voltage" otherwise is "Charge".
The default is ``False´´ in which case the "Charge" type is selected.
Whether the boundary is of type voltage or not. The default is ``False``.
This option is valid for Electrostatic solvers only.

Returns
-------
Expand Down Expand Up @@ -3406,6 +3405,8 @@
props = {"Edges": assignment}
if self.solution_type == "Electrostatic":
props["IsOfTypeVoltage"] = is_voltage
else:
self.logger.warning("Balloon boundary with type voltage is only valid for Electrostatic solvers.")

Check warning on line 3409 in src/ansys/aedt/core/maxwell.py

View check run for this annotation

Codecov / codecov/patch

src/ansys/aedt/core/maxwell.py#L3409 

Added line #L3409 was not covered by tests
return self._create_boundary(boundary, props, "Balloon")

@pyaedt_function_handler(input_edge="assignment", vectorvalue="vector_value", bound_name="boundary")
Expand Down
Loading