Skip to content

REFACTOR: Improve assign balloon method #6017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 9, 2025

Conversation

SMoraisAnsys
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys commented Apr 7, 2025

Description

Little follow up to #6011 (comment)
On top of updating the docstring (content and typo), I added a warning when the option is used for non Electrostatic solution type.

Issue linked

Associated to #5991

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@SMoraisAnsys SMoraisAnsys self-assigned this Apr 7, 2025
@SMoraisAnsys SMoraisAnsys requested a review from anur7 April 7, 2025 14:28
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.06%. Comparing base (d1c3dc3) to head (fdf00b3).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6017      +/-   ##
==========================================
+ Coverage   82.35%   85.06%   +2.70%     
==========================================
  Files         166      166              
  Lines       62980    62981       +1     
==========================================
+ Hits        51869    53574    +1705     
+ Misses      11111     9407    -1704     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Samuelopez-ansys Samuelopez-ansys merged commit 8a677ce into main Apr 9, 2025
43 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the refactor/update-assign-balloon-changes branch April 9, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants