Post Processor Report Refactoring #1017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1017 +/- ##
==========================================
- Coverage 80.87% 80.69% -0.19%
==========================================
Files 131 132 +1
Lines 39074 39610 +536
==========================================
+ Hits 31602 31963 +361
- Misses 7472 7647 +175 |
akaszynski
reviewed
Mar 31, 2022
pyaedt/modules/PostProcessor.py
Outdated
| } | ||
|
|
||
|
|
||
| class REPORTS(object): |
There was a problem hiding this comment.
Should reserve all CAPS for python constants and not classes.
akaszynski
reviewed
Mar 31, 2022
pyaedt/modules/PostProcessor.py
Outdated
| rep = rt.Standard(self._post_app, self._post_app._app.design_solutions.report_type, setup_name) | ||
| rep.expressions = expressions | ||
| return rep | ||
| return None |
There was a problem hiding this comment.
This is redundant. None is returned by default.
Suggested change
| return None |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.