Fix bug for flipped mount when rotation zero (#1009)

* Fix bug for flipped mount when rotation zero

get_component_placement_vector would return an incorrect Y-offset when
flipped was True and the rotation angle was calculated to be zero.  Add
a test case for and fix this by modifying the merged component pin
locations to account for the flip around the X-axis (Y-value changes
sign) so that the correct flipped values propagate through the rest of
the calculations.

* Feedback from review

Simplify offset calculation by not treating zero rotation as a special
case.  Also clean up the error checking for return: the existing code
implied that the vector calculation could fail when it could not and
would not capture a failure to get the solder ball height.

Author: isaacwaldron

_unittest/example_models/invert_board.aedb/edb.def

@@ -860,6 +860,24 @@ def test_79f_get_placement_vector_offset(self):
             chip_edb.close_edb()
             laminate_edb.close_edb()
 
+    def test_79g_get_placement_vector(self):
+        board_edb = Edb(os.path.join(local_path, "example_models", "invert_board.aedb"), edbversion=desktop_version)
+        package_edb = Edb(os.path.join(local_path, "example_models", "package2.aedb"), edbversion=desktop_version)
+        try:
+            laminate_cmp = board_edb.core_components.get_component_by_name("U100")
+            chip_cmp = package_edb.core_components.get_component_by_name("BGA")
+            result, vector, rotation, solder_ball_height = board_edb.core_components.get_component_placement_vector(
+                chip_cmp, laminate_cmp, "A12", "A14", "A12", "A14", True
+            )
+            assert result
+            assert abs(rotation) < 1e-9
+            assert abs(solder_ball_height - 315e-6) < 1e-9
+            assert abs(vector[0] + 48.7e-3) < 10e-9
+            assert abs(vector[1] - 59.7e-3) < 10e-9
+        finally:
+            package_edb.close_edb()
+            board_edb.close_edb()
+
     def test_80_edb_without_path(self):
         edbapp_without_path = Edb(edbversion=desktop_version, isreadonly=False)
         time.sleep(2)

_unittest/example_models/package2.aedb/edb.def

@@ -467,26 +467,23 @@ def get_component_placement_vector(
         if hosting_component_pin2:
             h_pin2 = self._get_edb_pin_from_pin_name(hosting_component, hosting_component_pin2)
             h_pin2_pos = self.get_pin_position(h_pin2)
-        #
-        vector = [h_pin1_pos[0] - m_pin1_pos[0], h_pin1_pos[1] - m_pin1_pos[1]]
+
+        if flipped:
+            m_pin1_pos[1] *= -1.0
+            m_pin2_pos[1] *= -1.0
+
         vector1 = GeometryOperators.v_points(m_pin1_pos, m_pin2_pos)
         vector2 = GeometryOperators.v_points(h_pin1_pos, h_pin2_pos)
-        multiplier = 1
-        if flipped:
-            multiplier = -1
-        vector1[1] = multiplier * vector1[1]
 
         rotation = GeometryOperators.v_angle_sign_2D(vector1, vector2, False)
-        if rotation != 0.0:
-            x_v2 = m_pin1_pos[0] * math.cos(rotation) + multiplier * m_pin1_pos[1] * math.sin(rotation)
-            y_v2 = -1 * m_pin1_pos[0] * math.sin(rotation) + multiplier * m_pin1_pos[1] * math.cos(rotation)
-            new_vector = [x_v2, y_v2]
-            vector = [h_pin1_pos[0] - new_vector[0], h_pin1_pos[1] - new_vector[1]]
-
-        if vector:
-            solder_ball_height = self.get_solder_ball_height(mounted_component)
+        offset_from_x = m_pin1_pos[0] * math.cos(rotation) + m_pin1_pos[1] * math.sin(rotation)
+        offset_from_y = -1 * m_pin1_pos[0] * math.sin(rotation) + m_pin1_pos[1] * math.cos(rotation)
+        vector = [h_pin1_pos[0] - offset_from_x, h_pin1_pos[1] - offset_from_y]
+
+        solder_ball_height = self.get_solder_ball_height(mounted_component)
+        if isinstance(solder_ball_height, float):
             return True, vector, rotation, solder_ball_height
-        self._logger.warning("Failed to compute vector.")
+        self._logger.warning("Failed to compute solder ball height.")
         return False, [0, 0], 0, 0
 
     @pyaedt_function_handler()