-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
feat: use setCollapsed
method from backend
#18770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
criticalAY
wants to merge
2
commits into
ankidroid:main
Choose a base branch
from
criticalAY:fix/undo-label
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+72
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an action was performed which did not update studyQueues then it would still update the undo status Fixes 18762
Does this duplicate: |
|
As discussed on Discord:
|
18e91fc
to
8cf8ca5
Compare
fix: undo label not updated in menu UI
8cf8ca5
to
6fc1943
Compare
setCollapsed
method from backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Blocked by dependency
Currently blocked by some other dependent / related change
Has Conflicts
Priority-Medium
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose / Description
The undo label was not correctly updated in the menu UI as on deck expansion the backend gets to know what to undo as it was called on expansion but the UI.
Fixes
Approach
How Has This Been Tested?
Pixel Fold API 35
Screen_recording_20250705_043559.webm
Learning (optional, can help others)
NA
Checklist
Please, go through these checks before submitting the PR.