Skip to content

feat: use setCollapsed method from backend #18770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

criticalAY
Copy link
Contributor

Purpose / Description

The undo label was not correctly updated in the menu UI as on deck expansion the backend gets to know what to undo as it was called on expansion but the UI.

Fixes

Approach

  • We stored a reference to the Menu in currentDeckPickerMenu so we can update menu items outside onCreateOptionsMenu().
  • We clear it in onDestroyView() to avoid memory leaks and stale references when the Fragment's view is destroyed.

How Has This Been Tested?

Pixel Fold API 35
Screen_recording_20250705_043559.webm

Learning (optional, can help others)

NA

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

If an action was performed which did not update studyQueues
then it would still update the undo status

Fixes 18762
@david-allison
Copy link
Member

Does this duplicate:

@criticalAY
Copy link
Contributor Author

criticalAY commented Jul 4, 2025

Yes seems like same issue, I put filter for medium priority, sorry missed it
Different bug sorry tested your PR

@criticalAY criticalAY requested a review from david-allison July 4, 2025 23:59
@criticalAY criticalAY added the Blocked by dependency Currently blocked by some other dependent / related change label Jul 5, 2025
@david-allison
Copy link
Member

david-allison commented Jul 5, 2025

As discussed on Discord:

@david-allison david-allison added Needs Author Reply Waiting for a reply from the original author Blocked by dependency Currently blocked by some other dependent / related change and removed Blocked by dependency Currently blocked by some other dependent / related change Needs Review Needs Author Reply Waiting for a reply from the original author labels Jul 5, 2025
@criticalAY criticalAY force-pushed the fix/undo-label branch 2 times, most recently from 18e91fc to 8cf8ca5 Compare July 5, 2025 19:39
fix: undo label not updated in menu UI
@criticalAY criticalAY changed the title fix: undo label not updated in menu UI feat: use setCollapsed method from backend Jul 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked by dependency Currently blocked by some other dependent / related change Has Conflicts Priority-Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "undo" deck entry should be updated automatically
2 participants