Skip to content

fix(deck-picker): 'undo' menu item not updated #18764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2025

Conversation

david-allison
Copy link
Member

@david-allison david-allison commented Jul 3, 2025

If an action was performed which did not update studyQueues then it would still update the undo status

How Has This Been Tested?

Unit test + brief manual test

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison
Copy link
Member Author

Not sure if we want to cherry pick this one to 2.21: 2.22 is coming very soon

@BrayanDSO BrayanDSO added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Jul 3, 2025
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am more enthusiastic about a 2.21.1 than trying to restabilize main for 2.22, I'd prefer for GSoC stuff to merge in (for GSoC morale) and other unsettling things to just go in without worry for a couple months than stabilize, so I'll try to pick it

@mikehardy mikehardy added Needs Author Reply Waiting for a reply from the original author Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) Queued for Cherry Pick to Stable Branch and removed Needs Second Approval Has one approval, one more approval to merge labels Jul 5, 2025
@mikehardy

This comment was marked as outdated.

@mikehardy
Copy link
Member

Never mind, I got it, pushing in a moment

@mikehardy mikehardy enabled auto-merge July 5, 2025 22:56
@mikehardy mikehardy removed Needs Author Reply Waiting for a reply from the original author Has Conflicts labels Jul 5, 2025
If an action was performed which did not update studyQueues
then it would still update the undo status

Fixes 18762

Co-authored-by: Mike Hardy <[email protected]>
@david-allison
Copy link
Member Author

fixed a lint issue

@mikehardy mikehardy added this pull request to the merge queue Jul 6, 2025
Merged via the queue into ankidroid:main with commit 02c962a Jul 6, 2025
9 checks passed
@github-actions github-actions bot added this to the 2.21 release milestone Jul 6, 2025
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jul 6, 2025
@david-allison david-allison deleted the deck-picker-undo branch July 14, 2025 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deck picker undo menu entry text not updated
3 participants