ME15: Added LP OVR Feature Support. #441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/clang-format-run |
1 similar comment
|
/clang-format-run |
|
/clang-format-run |
sihyung-maxim
requested review from
lorne-maxim,
Jacob-Scheiffler and
Jake-Carter
Jake-Carter
approved these changes
Feb 27, 2023
| } | ||
| } | ||
|
|
||
| // Caller must perform peripheral reset |
There was a problem hiding this comment.
Document this in the Doxygen header as well
|
Something is wrong with checking out the repo in the BLE_Examples_Test workflow (GitHub side issue). These changes aren't related to the BLE tests either and after talking with Eddie, it should be good to merge in even if the BLE test fails. |
|
|
||
| // Set the OVR bits | ||
| MXC_PWRSEQ->lpcn &= ~(MXC_F_PWRSEQ_LPCN_OVR); | ||
| MXC_PWRSEQ->lpcn |= ovr; |
There was a problem hiding this comment.
I'd suggest using MXC_Setfield here to ensure ovr doesn't overwrite any other field in that register or check that it's a valid selection beforehand.
Jacob-Scheiffler
approved these changes
Feb 27, 2023
Jake-Carter
pushed a commit
that referenced
this pull request
Mar 7, 2023
* ME15: Added LP OVR Feature Support. * Updating lp_me15.c for clang-formatting error. * Clang-formatted lp_me15.c locally. * ME16 LP: Updated OVR enum values. * ME16 LP: Fixed function prototype. * LP OVR: Added note in doxygen header for peripheral reset. * LP OVR: Removed @note from doxygen. * LP ME15: Ensure appropriate control bit is set for OVR. * Fixed syntax error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added LP Operating Voltage Range Select Support.