chore: update unit test coverage to 100% on util files #2139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Golodhros
requested review from
ttannis,
allisonsuarez,
feng-tao,
dorianj,
verdan,
mgorsk1,
sewardgw,
youngyjd,
dechoma and
kristenarmes
as code owners
feng-tao
approved these changes
Apr 13, 2023
Signed-off-by: Marcos Iglesias <[email protected]>
kristenarmes
approved these changes
Apr 13, 2023
Comment on lines
59
to
65
| const expected = undefined; | ||
| const actual = TextUtils.convertText( | ||
| expected, | ||
| TextUtils.CaseType.TITLE_CASE | ||
| ); | ||
|
|
||
| expect(actual).toEqual(''); |
There was a problem hiding this comment.
nit suggestion for readability so the expected value is equal to the result
Suggested change
| const expected = undefined; | |
| const actual = TextUtils.convertText( | |
| expected, | |
| TextUtils.CaseType.TITLE_CASE | |
| ); | |
| expect(actual).toEqual(''); | |
| const expected = ''; | |
| const actual = TextUtils.convertText( | |
| undefined, | |
| TextUtils.CaseType.TITLE_CASE | |
| ); | |
| expect(actual).toEqual(expected); |
There was a problem hiding this comment.
Good call! A copy/paste error.
Changing it
Signed-off-by: Marcos Iglesias <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds tests to cover all the util codes in the frontend
Refactors tests and file names
Motivation and Context
Increasing test coverage
How Has This Been Tested?
Ran tests
CheckList