amundsen-io · Golodhros · Apr 13, 2023 · Apr 10, 2023 · Apr 12, 2023 · Apr 12, 2023
@@ -9,18 +9,12 @@ exports[`eslint`] = {
       [71, 6, 118, "Visible, non-interactive elements with click handlers must have at least one keyboard listener.", "3051403928"],
       [71, 6, 118, "Static HTML elements with event handlers require a role.", "3051403928"]
     ],
-    "js/components/EditableText/index.tsx:1409200205": [
-      [79, 6, 13, "Do not use setState in componentDidUpdate", "57229240"],
-      [97, 6, 13, "Do not use setState in componentDidUpdate", "57229240"],
-      [154, 19, 20, "Script URL is a form of eval.", "3373049033"]
-    ],
-    "js/components/OwnerEditor/index.tsx:4022954541": [
-      [85, 6, 13, "Do not use setState in componentDidUpdate", "57229240"],
-      [153, 13, 24, "Must use destructuring state assignment", "1659627107"],
-      [153, 13, 10, "Use callback in setState when referencing the previous state.", "4014904506"],
-      [168, 8, 3, "Assignment to property of function parameter \'obj\'.", "193420290"],
-      [209, 23, 24, "Must use destructuring state assignment", "1659627107"],
-      [211, 48, 24, "Must use destructuring state assignment", "1659627107"]
+    "js/components/EditableText/index.tsx:175217081": [
+      [82, 6, 13, "Do not use setState in componentDidUpdate", "57229240"],
+      [100, 6, 13, "Do not use setState in componentDidUpdate", "57229240"]
+    ],
+    "js/components/OwnerEditor/index.tsx:2385247435": [
+      [85, 6, 13, "Do not use setState in componentDidUpdate", "57229240"]
     ],
     "js/components/Preloader/index.tsx:958787996": [
       [22, 4, 26, "Must use destructuring props assignment", "1492876559"],
@@ -65,9 +59,9 @@ exports[`eslint`] = {
       [19, 2, 8, "Assignment to function parameter \'resource\'.", "2131237679"],
       [20, 2, 248, "Expected a default case.", "1034339850"]
     ],
-    "js/ducks/tableMetadata/api/v0.ts:893844129": [
-      [95, 6, 9, "Assignment to property of function parameter \'tableData\'.", "1466754955"],
-      [144, 23, 2, "Expected to return a value at the end of arrow function.", "5859494"]
+    "js/ducks/tableMetadata/api/v0.ts:3333048528": [
+      [92, 6, 9, "Assignment to property of function parameter \'tableData\'.", "1466754955"],
+      [141, 23, 2, "Expected to return a value at the end of arrow function.", "5859494"]
     ],
     "js/ducks/tableMetadata/reducer.ts:3935312006": [
       [482, 6, 84, "Unexpected lexical declaration in case block.", "114266473"]
@@ -95,7 +89,7 @@ exports[`eslint`] = {
       [135, 6, 12, "Assignment to function parameter \'currentIndex\'.", "2078922066"],
       [178, 4, 10, "Assignment to function parameter \'columnType\'.", "460876587"]
     ],
-    "js/features/Footer/index.tsx:3032041713": [
+    "js/features/Footer/index.tsx:3658564998": [
       [45, 8, 22, "Must use destructuring props assignment", "1925601400"],
       [49, 12, 22, "Must use destructuring props assignment", "1925601400"]
     ],
@@ -120,16 +114,16 @@ exports[`eslint`] = {
     "js/pages/DashboardPage/QueryList/index.tsx:2324422660": [
       [14, 0, 516, "Component should be written as a pure function", "698708664"]
     ],
-    "js/pages/DashboardPage/index.tsx:3424122174": [
-      [131, 6, 13, "Do not use setState in componentDidUpdate", "57229240"]
+    "js/pages/DashboardPage/index.tsx:1714082706": [
+      [127, 6, 13, "Do not use setState in componentDidUpdate", "57229240"]
     ],
     "js/pages/HomePage/index.tsx:2768486505": [
       [59, 4, 22, "Must use destructuring props assignment", "2151395318"]
     ],
-    "js/pages/ProfilePage/index.tsx:4225862884": [
-      [108, 23, 16, "Must use destructuring props assignment", "1899951550"],
-      [110, 19, 17, "Must use destructuring state assignment", "3172298888"],
-      [111, 6, 13, "Do not use setState in componentDidUpdate", "57229240"]
+    "js/pages/ProfilePage/index.tsx:2077253528": [
+      [104, 23, 16, "Must use destructuring props assignment", "1899951550"],
+      [106, 19, 17, "Must use destructuring state assignment", "3172298888"],
+      [107, 6, 13, "Do not use setState in componentDidUpdate", "57229240"]
     ],
     "js/pages/SearchPage/ResourceSelector/index.tsx:1426301798": [
       [67, 19, 19, "Must use destructuring props assignment", "3960624135"]
@@ -153,11 +147,8 @@ exports[`eslint`] = {
     "js/pages/TableDetailPage/TableOwnerEditor/index.tsx:2069554136": [
       [30, 4, 3, "Assignment to property of function parameter \'obj\'.", "193420290"]
     ],
-    "js/utils/ownerUtils.ts:2186084439": [
+    "js/utils/owner.ts:2186084439": [
       [10, 4, 9, "Assignment to property of function parameter \'resultObj\'.", "1686251499"]
-    ],
-    "js/utils/textUtils.ts:4144938777": [
-      [19, 6, 46, "Unexpected lexical declaration in case block.", "156477898"]
     ]
   }`
 };
@@ -4,7 +4,7 @@
 import React from 'react';
 
 import { BadgeStyle } from 'config/config-types';
-import { CaseType } from 'utils/textUtils';
+import { CaseType } from 'utils/text';
 import StorySection from '../StorySection';
 import Flag from '.';
 

@@ -4,7 +4,7 @@
 import * as React from 'react';
 
 import { BadgeStyle } from 'config/config-types';
-import { convertText, CaseType } from 'utils/textUtils';
+import { convertText, CaseType } from 'utils/text';
 
 import './styles.scss';
 

@@ -9,7 +9,7 @@ import BookmarkIcon from 'components/Bookmark/BookmarkIcon';
 import { ResourceType } from 'interfaces';
 
 import * as ConfigUtils from 'config/config-utils';
-import * as DateUtils from 'utils/dateUtils';
+import * as DateUtils from 'utils/date';
 
 import { dashboardSummary } from 'fixtures/metadata/dashboard';
 import { NO_TIMESTAMP_TEXT } from '../../../constants';
@@ -25,7 +25,7 @@ jest.mock('config/config-utils', () => ({
   getSourceDisplayName: jest.fn(() => MOCK_DISPLAY_NAME),
   getSourceIconClass: jest.fn(() => MOCK_ICON_CLASS),
 }));
-jest.mock('utils/dateUtils', () => ({
+jest.mock('utils/date', () => ({
   formatDate: jest.fn(() => MOCK_DATE),
 }));
 

@@ -8,8 +8,8 @@ import BookmarkIcon from 'components/Bookmark/BookmarkIcon';
 
 import { getSourceDisplayName, getSourceIconClass } from 'config/config-utils';
 import { logClick } from 'utils/analytics';
-import { buildDashboardURL } from 'utils/navigationUtils';
-import { formatDate } from 'utils/dateUtils';
+import { buildDashboardURL } from 'utils/navigation';
+import { formatDate } from 'utils/date';
 
 import { ResourceType, DashboardResource } from 'interfaces';
 

@@ -1,6 +1,6 @@
 import AppConfig from 'config/config';
 import { BadgeStyle, BadgeStyleConfig } from 'config/config-types';
-import { convertText, CaseType } from 'utils/textUtils';
+import { convertText, CaseType } from 'utils/text';
 
 import { TableMetadata } from 'interfaces/TableMetadata';
 import { ResourceType } from '../interfaces';

@@ -3,7 +3,7 @@ import { SagaIterator } from 'redux-saga';
 import { all, call, put, select, takeEvery } from 'redux-saga/effects';
 
 import { ResourceType } from 'interfaces/Resources';
-import { createOwnerUpdatePayload } from 'utils/ownerUtils';
+import { createOwnerUpdatePayload } from 'utils/owner';
 import { getFeatureLineage } from 'ducks/lineage/api/v0';
 import { GetFeatureLineage } from 'ducks/lineage/types';
 import * as API from './api/v0';

@@ -7,7 +7,7 @@ import {
   UserResource,
 } from 'interfaces';
 
-import * as NavigationUtils from 'utils/navigationUtils';
+import * as NavigationUtils from 'utils/navigation';
 
 import globalState from 'fixtures/globalState';
 

@@ -12,7 +12,7 @@ import * as qs from 'simple-query-string';
 
 import { ResourceType, SearchType } from 'interfaces';
 
-import { BrowserHistory, updateSearchUrl } from 'utils/navigationUtils';
+import { BrowserHistory, updateSearchUrl } from 'utils/navigation';
 import { getSearchResultsPerPage } from 'config/config-utils';
 import * as API from './api/v0';
 

@@ -7,7 +7,7 @@ import {
   TableResource,
 } from 'interfaces';
 
-import * as NavigationUtils from 'utils/navigationUtils';
+import * as NavigationUtils from 'utils/navigation';
 import * as SearchUtils from 'ducks/search/utils';
 
 import globalState from 'fixtures/globalState';

@@ -15,10 +15,7 @@ import {
 
 /** HELPERS **/
 import { indexDashboardsEnabled } from 'config/config-utils';
-import {
-  createOwnerUpdatePayload,
-  getOwnersDictFromUsers,
-} from 'utils/ownerUtils';
+import { createOwnerUpdatePayload, getOwnersDictFromUsers } from 'utils/owner';
 import {
   getTableQueryParams,
   getRelatedDashboardSlug,

@@ -6,7 +6,7 @@ import * as React from 'react';
 import { getBadgeConfig } from 'config/config-utils';
 import { BadgeStyle, BadgeStyleConfig } from 'config/config-types';
 
-import { convertText, CaseType } from 'utils/textUtils';
+import { convertText, CaseType } from 'utils/text';
 import { logClick } from 'utils/analytics';
 
 import { Badge } from 'interfaces/Badges';

@@ -7,7 +7,7 @@ import { shallow } from 'enzyme';
 import ExpandableUniqueValues from 'features/ExpandableUniqueValues';
 import BadgeList from 'features/BadgeList';
 import RequestDescriptionText from 'pages/TableDetailPage/RequestDescriptionText';
-import { getColumnLink } from 'utils/navigationUtils';
+import { getColumnLink } from 'utils/navigation';
 import * as Analytics from 'utils/analytics';
 import ColumnDescEditableText from '../ColumnDescEditableText';
 import ColumnStats from '../ColumnStats';

@@ -21,7 +21,7 @@ import {
   isColumnListLineageEnabled,
   notificationsEnabled,
 } from 'config/config-utils';
-import { buildTableKey, getColumnLink } from 'utils/navigationUtils';
+import { buildTableKey, getColumnLink } from 'utils/navigation';
 import { filterOutUniqueValues, getUniqueValues } from 'utils/stats';
 import { logClick } from 'utils/analytics';
 import {

@@ -3,7 +3,7 @@
 
 import * as React from 'react';
 
-import { formatNumber, isNumber } from 'utils/numberUtils';
+import { formatNumber, isNumber } from 'utils/number';
 import { getStatsInfoText } from 'utils/stats';
 
 import { TableColumnStats } from 'interfaces/index';

@@ -26,7 +26,7 @@ import {
 } from 'interfaces';
 import { FormattedDataType, ContentType } from 'interfaces/ColumnList';
 import { logAction } from 'utils/analytics';
-import { buildTableKey, TablePageParams } from 'utils/navigationUtils';
+import { buildTableKey, TablePageParams } from 'utils/navigation';
 
 import { GraphIcon } from 'components/SVGIcons/GraphIcon';
 

@@ -4,7 +4,7 @@
 import * as React from 'react';
 import { Modal } from 'react-bootstrap';
 
-import { formatNumber, isNumber } from 'utils/numberUtils';
+import { formatNumber, isNumber } from 'utils/number';
 
 import { ColumnUniqueValues } from 'interfaces/index';
 

@@ -6,7 +6,7 @@ import { shallow } from 'enzyme';
 
 import globalState from 'fixtures/globalState';
 
-import * as DateUtils from 'utils/dateUtils';
+import * as DateUtils from 'utils/date';
 import { Footer, FooterProps, mapDispatchToProps, mapStateToProps } from '.';
 
 const MOCK_DATE_STRING = 'Jan 1 2000 at 0:00:00 am';

@@ -9,7 +9,7 @@ import { GlobalState } from 'ducks/rootReducer';
 import { getLastIndexed } from 'ducks/lastIndexed/reducer';
 import { GetLastIndexedRequest } from 'ducks/lastIndexed/types';
 
-import { formatDateTimeLong } from 'utils/dateUtils';
+import { formatDateTimeLong } from 'utils/date';
 
 import './styles.scss';
 

@@ -11,7 +11,7 @@ import {
   indexFeaturesEnabled,
   indexUsersEnabled,
 } from 'config/config-utils';
-import { buildDashboardURL } from 'utils/navigationUtils';
+import { buildDashboardURL } from 'utils/navigation';
 
 import { GlobalState } from 'ducks/rootReducer';
 import {

@@ -17,7 +17,7 @@ import { getDocumentTitle } from 'config/config-utils';
 import { analyticsMiddleware } from 'ducks/middlewares';
 
 import { logAction } from 'utils/analytics';
-import { BrowserHistory } from 'utils/navigationUtils';
+import { BrowserHistory } from 'utils/navigation';
 
 import { pageViewed } from 'ducks/ui';
 import rootReducer from 'ducks/rootReducer';

@@ -7,7 +7,7 @@ import {
   TypeMetadata,
 } from 'interfaces/TableMetadata';
 import { Badge } from 'interfaces/Badges';
-import { TablePageParams } from '../utils/navigationUtils';
+import { TablePageParams } from '../utils/navigation';
 
 export type ContentType = {
   title: string;

@@ -10,7 +10,7 @@ import OwnerEditor, {
   StateFromProps,
 } from 'components/OwnerEditor';
 
-import { getOwnerItemPropsFromUsers } from 'utils/ownerUtils';
+import { getOwnerItemPropsFromUsers } from 'utils/owner';
 
 export const DASHBOARD_OWNER_SOURCE = 'dashboard_page_owner';
 

@@ -29,12 +29,8 @@ import {
   getSourceIconClass,
   getResourceNotices,
 } from 'config/config-utils';
-import { formatDateTimeShort } from 'utils/dateUtils';
-import {
-  getLoggingParams,
-  getUrlParam,
-  setUrlParam,
-} from 'utils/navigationUtils';
+import { formatDateTimeShort } from 'utils/date';
+import { getLoggingParams, getUrlParam, setUrlParam } from 'utils/navigation';
 
 import { ResourceType } from 'interfaces';
 import { DashboardMetadata } from 'interfaces/Dashboard';

@@ -5,7 +5,7 @@ import { GlobalState } from 'ducks/rootReducer';
 
 import globalState from 'fixtures/globalState';
 import { activeUser0 } from 'fixtures/metadata/users';
-import { getOwnerItemPropsFromUsers } from 'utils/ownerUtils';
+import { getOwnerItemPropsFromUsers } from 'utils/owner';
 import { FEATURE_OWNER_SOURCE, mapDispatchToProps, mapStateToProps } from '.';
 
 describe('mapStateToProps', () => {

@@ -10,7 +10,7 @@ import OwnerEditor, {
   StateFromProps,
 } from 'components/OwnerEditor';
 
-import { getOwnerItemPropsFromUsers } from 'utils/ownerUtils';
+import { getOwnerItemPropsFromUsers } from 'utils/owner';
 import { bindActionCreators } from 'redux';
 import { updateFeatureOwner } from 'ducks/feature/reducer';
 

@@ -39,12 +39,8 @@ import { PreviewDataTable } from 'features/PreviewData';
 import { FeatureMetadata, FeaturePreviewQueryParams } from 'interfaces/Feature';
 import { ResourceType } from 'interfaces/Resources';
 import { logAction } from 'utils/analytics';
-import {
-  getLoggingParams,
-  getUrlParam,
-  setUrlParam,
-} from 'utils/navigationUtils';
-import { formatDateTimeShort } from 'utils/dateUtils';
+import { getLoggingParams, getUrlParam, setUrlParam } from 'utils/navigation';
+import { formatDateTimeShort } from 'utils/date';
 import { ProgrammaticDescription } from 'interfaces';
 import EditableText from 'components/EditableText';
 import FeatureDescEditableText from './FeatureDescEditableText';

@@ -18,7 +18,7 @@ import Breadcrumb from 'features/Breadcrumb';
 import GraphLoading from 'components/Lineage/GraphLoading';
 import GraphContainer from 'components/Lineage/GraphContainer';
 import { getTableLineageDefaultDepth } from 'config/config-utils';
-import { buildTableKey } from 'utils/navigationUtils';
+import { buildTableKey } from 'utils/navigation';
 
 import * as Constants from './constants';
 

@@ -15,7 +15,7 @@ import globalState from 'fixtures/globalState';
 import { getMockRouterProps } from 'fixtures/mockRouter';
 import { ResourceType } from 'interfaces/Resources';
 
-import * as NavigationUtils from 'utils/navigationUtils';
+import * as NavigationUtils from 'utils/navigation';
 
 import { indexDashboardsEnabled } from 'config/config-utils';
 import { AVATAR_SIZE, PROFILE_TAB } from './constants';

@@ -29,11 +29,7 @@ import {
   indexDashboardsEnabled,
 } from 'config/config-utils';
 
-import {
-  getLoggingParams,
-  getUrlParam,
-  setUrlParam,
-} from 'utils/navigationUtils';
+import { getLoggingParams, getUrlParam, setUrlParam } from 'utils/navigation';
 
 import {
   AVATAR_SIZE,

@@ -5,7 +5,7 @@ import * as React from 'react';
 import { MemoryRouter } from 'react-router-dom';
 import { mount } from 'enzyme';
 
-import * as NavigationUtils from 'utils/navigationUtils';
+import * as NavigationUtils from 'utils/navigation';
 import { TableMetadata } from 'interfaces/TableMetadata';
 
 import LineageButton from '.';

@@ -6,7 +6,7 @@ import { Link } from 'react-router-dom';
 
 import { TableMetadata } from 'interfaces';
 import { isTableLineagePageEnabled } from 'config/config-utils';
-import { buildLineageURL } from 'utils/navigationUtils';
+import { buildLineageURL } from 'utils/navigation';
 
 export interface LineageButtonProps {
   tableData: TableMetadata;

@@ -16,7 +16,7 @@ import {
 } from 'ducks/tableMetadata/reducer';
 import { IconSizes } from 'interfaces';
 import { TableQualityChecks } from 'interfaces/TableMetadata';
-import { formatDateTimeShort } from 'utils/dateUtils';
+import { formatDateTimeShort } from 'utils/date';
 import { FailureIcon } from 'components/SVGIcons/FailureIcon';
 import { SuccessIcon } from 'components/SVGIcons/SuccessIcon';
 import * as Constants from './constants';