Skip to content

fix: clean up ML features page #2118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2023
Merged

fix: clean up ML features page #2118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4639569
fix: clean up ML features page
allisonsuarez Mar 16, 2023
1b5e339
lint
allisonsuarez Mar 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/amundsen_application/static/js/pages/FeaturePage/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export const FEATURE_GROUP_TITLE = 'Feature Group';
export const LAST_UPDATED_TITLE = 'Last Updated';
export const OWNERS_TITLE = 'Owners';
export const PARTITION_KEY_TITLE = 'Partition Key';
export const SOURCE_TITLE = 'Source';
export const AVAILABILITY_TITLE = 'Availability';
export const TAG_TITLE = 'Tags';
export const VERSION_TITLE = 'Version';

Expand Down
14 changes: 8 additions & 6 deletions frontend/amundsen_application/static/js/pages/FeaturePage/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ import {
LAST_UPDATED_TITLE,
OWNERS_TITLE,
PARTITION_KEY_TITLE,
SOURCE_TITLE,
AVAILABILITY_TITLE,
TAG_TITLE,
VERSION_TITLE,
UPSTREAM_TAB_TITLE,
Expand Down Expand Up @@ -304,9 +304,9 @@ export const FeaturePage: React.FC<FeaturePageProps> = ({
{feature.feature_group}.{feature.name}.{feature.version}
</h1>
<p className="header-subtitle text-body-w3">
{getDisplayNameByResource(ResourceType.feature)}
{sourcesWithDisplay.length > 0 && <>&nbsp;&bull;&nbsp;</>}
{sourcesWithDisplay.join(', ')}
<ul className="header-bullets">
<li>{getDisplayNameByResource(ResourceType.feature)}</li>
</ul>
{feature.badges.length > 0 && <BadgeList badges={feature.badges} />}
</p>
</section>
Expand All @@ -333,8 +333,10 @@ export const FeaturePage: React.FC<FeaturePageProps> = ({
{feature.data_type}
</section>
<section className="metadata-section">
<h3 className="section-title text-title-w3">{SOURCE_TITLE}</h3>
{feature.availability}
<h3 className="section-title text-title-w3">
{AVAILABILITY_TITLE}
</h3>
{sourcesWithDisplay.join(', ')}
</section>
<section className="metadata-section">
<h3 className="section-title text-title-w3">
Expand Down