Skip to content

fix: clean up ML features page #2118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 20, 2023
Merged

fix: clean up ML features page #2118

merged 2 commits into from
Mar 20, 2023

Conversation

allisonsuarez
Copy link
Contributor

@allisonsuarez allisonsuarez commented Mar 16, 2023 •
edited
Loading

Description

  • Fix naming of sections
  • Fix header spacing

Motivation and Context

How Has This Been Tested?

  • local dev environment

Documentation

CheckList

  • PR title addresses the issue accurately and concisely
  • Updates Documentation and Docstrings
  • Adds tests
  • Adds instrumentation (logs, or UI events)

@allisonsuarez
fix: clean up ML features page
4639569 
Signed-off-by: Allison Suarez Miranda <[email protected]>
@boring-cyborg boring-cyborg bot added the area:frontend From the Frontend folder label Mar 16, 2023
@allisonsuarez
lint
1b5e339 
Signed-off-by: Allison Suarez Miranda <[email protected]>
@allisonsuarez allisonsuarez marked this pull request as ready for review March 20, 2023 17:07
Golodhros
Golodhros approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@allisonsuarez allisonsuarez merged commit 34b7eef into main Mar 20, 2023
@allisonsuarez allisonsuarez deleted the asm-feature-pageevampr branch March 20, 2023 17:12
B-T-D pushed a commit to B-T-D/amundsen that referenced this pull request Mar 29, 2023
@allisonsuarez @B-T-D
fix: clean up ML features page (amundsen-io#2118)
4fe75d5 
* fix: clean up ML features page

Signed-off-by: Allison Suarez Miranda <[email protected]>

* lint

Signed-off-by: Allison Suarez Miranda <[email protected]>

---------

Signed-off-by: Allison Suarez Miranda <[email protected]>
Signed-off-by: Ben Dye <[email protected]>
B-T-D pushed a commit to B-T-D/amundsen that referenced this pull request Mar 29, 2023
@allisonsuarez @B-T-D
fix: clean up ML features page (amundsen-io#2118)
0252adc 
* fix: clean up ML features page

Signed-off-by: Allison Suarez Miranda <[email protected]>

* lint

Signed-off-by: Allison Suarez Miranda <[email protected]>

---------

Signed-off-by: Allison Suarez Miranda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Golodhros Golodhros Golodhros approved these changes

@kristenarmes kristenarmes kristenarmes approved these changes

@ttannis ttannis Awaiting requested review from ttannis ttannis is a code owner

@feng-tao feng-tao Awaiting requested review from feng-tao feng-tao is a code owner

@dorianj dorianj Awaiting requested review from dorianj

@verdan verdan Awaiting requested review from verdan verdan is a code owner

@mgorsk1 mgorsk1 Awaiting requested review from mgorsk1 mgorsk1 is a code owner

@sewardgw sewardgw Awaiting requested review from sewardgw sewardgw is a code owner

@youngyjd youngyjd Awaiting requested review from youngyjd youngyjd is a code owner

@dechoma dechoma Awaiting requested review from dechoma dechoma is a code owner

Assignees
No one assigned
Labels
area:frontend From the Frontend folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@allisonsuarez @Golodhros @kristenarmes