Skip to content

Fixes UI crashing on "search page" if we multiple filters with the same category are added (issue #2053) #2057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 12, 2022
Merged

Fixes UI crashing on "search page" if we multiple filters with the same category are added (issue #2053) #2057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f75ea9
Fixes UI crashing on "search page" if we multiple filters with the sa…
mikaalanwar Dec 12, 2022
1bad028
Update unit tests for changes
mikaalanwar Dec 12, 2022
3354a7f
fix: lint
ozandogrultan Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/amundsen_application/static/js/pages/SearchPage/SearchFilter/index.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,9 +199,9 @@ describe('SearchFilter', () => {
});

it('calls createFilterSection with correct key and section for each props.filterSections', () => {
props.filterSections.forEach((section) => {
props.filterSections.forEach((section, index) => {
expect(createFilterSectionSpy).toHaveBeenCalledWith(
`section:${section.categoryId}`,
`section:${section.categoryId}-${index}`,
section
);
});
Expand Down
7 changes: 5 additions & 2 deletions frontend/amundsen_application/static/js/pages/SearchPage/SearchFilter/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,11 @@ export class SearchFilter extends React.Component<SearchFilterProps> {
};

renderFilterSections = (filterSections) =>
filterSections.map((section) =>
this.createFilterSection(`section:${section.categoryId}`, section)
filterSections.map((section, index) =>
this.createFilterSection(
`section:${section.categoryId}-${index}`,
section
)
);

render = () => {
Expand Down