Skip to content

Fixes UI crashing on "search page" if we multiple filters with the same category are added (issue #2053) #2057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mikaalanwar
Copy link
Contributor

@mikaalanwar mikaalanwar commented Dec 12, 2022

Signed-off-by: Muhammad Mikaal S. Anwar [email protected]

This PR provides a fix for the issue by allowing multiple search filters per category.

Summary of Changes

The section filter key is updated to be unique (by appending an index) in order to ensure it gets re-rendered properly upon each transition of resource type (switching back and forth from Tables to Dashboards) on the search page.

Tests

It's a minor change in internal to a component so no further testing was needed. Relevant tests have been updated accordingly.

Documentation

N/A

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

…me category are added (issue amundsen-io#2053)

Signed-off-by: Muhammad Mikaal S. Anwar <[email protected]>
mikaalanwar and others added 2 commits December 12, 2022 14:11
Signed-off-by: Muhammad Mikaal S. Anwar <[email protected]>
Signed-off-by: Ozan Dogrultan <[email protected]>
Copy link
Contributor

@kristenarmes kristenarmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@kristenarmes kristenarmes merged commit d0e36a2 into amundsen-io:main Dec 12, 2022
@Golodhros
Copy link
Member

thanks for the fix!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend From the Frontend folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants