Fixes UI crashing on "search page" if we multiple filters with the same category are added (issue #2053) #2057
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Muhammad Mikaal S. Anwar [email protected]
This PR provides a fix for the issue by allowing multiple search filters per category.
Summary of Changes
The section filter key is updated to be unique (by appending an index) in order to ensure it gets re-rendered properly upon each transition of resource type (switching back and forth from Tables to Dashboards) on the search page.
Tests
It's a minor change in internal to a component so no further testing was needed. Relevant tests have been updated accordingly.
Documentation
N/A
CheckList
Make sure you have checked all steps below to ensure a timely review.