-
Notifications
You must be signed in to change notification settings - Fork 970
fix: Add postgres compatibility in PrestoViewMetadataExtractor #1878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add postgres compatibility in PrestoViewMetadataExtractor #1878
Conversation
Congratulations on your first Pull Request and welcome to Amundsen community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/amundsen-io/amundsen/blob/main/CONTRIBUTING.md) |
36506b6
to
d810848
Compare
d810848
to
71a3191
Compare
@chonyy could you update the pr with rebase and fix the ci ? will take a look once it is updated |
@feng-tao Thanks! Will be working on passing the unit tests 😄 |
ping |
cd68a6c
to
1635136
Compare
Signed-off-by: Tony Chou <[email protected]>
…her it's postgres or not Signed-off-by: Tony Chou <[email protected]>
1635136
to
5a8fae1
Compare
Hi @feng-tao , all ci unit tests are passed. Pls help me take a look at it when you have time, thanks 🙏 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Summary of Changes
Tests
This change has been running in our production environment for a couple of months. I believe no additional unit test is needed since it's simply fixing an unexpected behavior.
CheckList
Make sure you have checked all steps below to ensure a timely review.