-
Notifications
You must be signed in to change notification settings - Fork 970
fix: relax pandas version requirements for databuilder #1858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: relax pandas version requirements for databuilder #1858
Conversation
Congratulations on your first Pull Request and welcome to Amundsen community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/amundsen-io/amundsen/blob/main/CONTRIBUTING.md) |
You raise a very good point, which begs the question couldn't this part be refactored to use the |
There is a unit test error, which seems to be related to fastapi imports:
I saw it in other builds such as https://github.com/amundsen-io/amundsen/runs/6338504223, so I suspect it's not related |
|
@feng-tao This is a unit test import error that does not relate to our change. Any way we could get past it or get our PR merged? |
9df34e0
to
60f99b6
Compare
Signed-off-by: Henri Dwyer <[email protected]>
60f99b6
to
801726d
Compare
I saw a fix for the fastapi bug was merged. So I rebased this branch @feng-tao |
thanks @henridwyer |
Awesome work, congrats on your first merged pull request! |
Summary of Changes
Relax the pandas version requirements for the databuilder package, which is currently limited to a version released over 2 year ago, to allow for more recent versions. This will make it possible to easily include the package in repos that use modern versions of pandas.
Tests
Tested on pandas 1.4.2 (the current version).
Pandas usage was already tested in unit tests so no new tests are necessary.
Documentation
Very little of the pandas API is used, essentially just
read_csv
, which is a very stable part of the API.CheckList
Make sure you have checked all steps below to ensure a timely review.