Skip to content

Ensure site icon in legacy template is identified as a hero image #6403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 22, 2021
Merged

Ensure site icon in legacy template is identified as a hero image #6403

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bed5c82
Add data-hero-candidate attr to .amp-wp-site-icon
westonruter Jun 20, 2021
c921c16
Let .amp-wp-site-icon be img in template so it can convert to amp-img
westonruter Jun 20, 2021
6d69152
Add alt attribute to .amp-wp-site-icon
westonruter Jun 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion templates/header-bar.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<a href="<?php echo esc_url( $this->get( 'home_url' ) ); ?>">
<?php $site_icon_url = $this->get( 'site_icon_url' ); ?>
<?php if ( $site_icon_url ) : ?>
<amp-img src="<?php echo esc_url( $site_icon_url ); ?>" width="32" height="32" class="amp-wp-site-icon"></amp-img>
<img src="<?php echo esc_url( $site_icon_url ); ?>" width="32" height="32" class="amp-wp-site-icon" data-hero-candidate alt="<?php esc_attr_e( 'Site icon', 'amp' ); ?>">
<?php endif; ?>
<span class="amp-site-title">
<?php echo esc_html( wptexturize( $this->get( 'blog_name' ) ) ); ?>
Expand Down