Ensure site icon in legacy template is identified as a hero image #6403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Plugin builds for 6d69152 are ready 🛎️!
|
pierlon
approved these changes
Jun 21, 2021
|
QA Passed I added a Site Icon and changed the template mode to Reader with the legacy theme:
The logo was rendered as a hero: <amp-img src="https://wordpress-stable.lndo.site/wp-content/uploads/2021/04/cropped-amp-wp-logo-32x32.png" width="32" height="32" class="amp-wp-site-icon amp-wp-enforced-sizes i-amphtml-layout-intrinsic i-amphtml-layout-size-defined" data-hero-candidate="" alt="Site icon" layout="intrinsic" data-hero i-amphtml-ssr i-amphtml-layout="intrinsic">
<i-amphtml-sizer class="i-amphtml-sizer">
<img alt="" aria-hidden="true" class="i-amphtml-intrinsic-sizer" role="presentation" src="data:image/svg+xml;base64,PHN2ZyBoZWlnaHQ9IjMyIiB3aWR0aD0iMzIiIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyIgdmVyc2lvbj0iMS4xIi8+">
</i-amphtml-sizer>
<img class="i-amphtml-fill-content i-amphtml-replaced-content" decoding="async" alt="Site icon" src="https://wordpress-stable.lndo.site/wp-content/uploads/2021/04/cropped-amp-wp-logo-32x32.png">
</amp-img> |
|
In testing this, I did find that the hero image failed to get identified for an image block which appears at the beginning of the content in the legacy Reader templates. Fix submitted in #6440. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Discovered when testing #6402.
data-hero-candidateto.amp-wp-site-icon..amp-wp-site-iconbeimgin template so it can convert toamp-img.altattribute to.amp-wp-site-icon.Checklist