Skip to content

Improve hero image determination #6062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Apr 15, 2021
Merged

Improve hero image determination #6062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
2e40142
Include DetermineHeroImages on non-core themes as well
westonruter Apr 9, 2021
0521582
Improve identification of images in header
westonruter Apr 9, 2021
9a65ecc
Gather custom logo along with other header images
westonruter Apr 9, 2021
f9bff05
Update tests for DetermineHeroImages
westonruter Apr 10, 2021
0549326
Expand prerendering to any initial block containing an image
westonruter Apr 10, 2021
f27dab7
Use Element instead of DOMElement
westonruter Apr 10, 2021
0ce975a
Add test to ensure tiny image at beginning of entry-content is not ma…
westonruter Apr 10, 2021
5100cd4
Update amp-toolbox-php to https://github.com/ampproject/amp-toolbox-p…
westonruter Apr 11, 2021
d042d35
Merge branch 'develop' of github.com:ampproject/amp-wp into fix/hero-…
westonruter Apr 14, 2021
23f1d7b
Update amp-toolbox-php to 0.4.0
westonruter Apr 14, 2021
0e8de7f
Merge branch 'develop' of github.com:ampproject/amp-wp into fix/hero-…
westonruter Apr 14, 2021
08d2e83
Update amp-toolbox-php to dev-main to include https://github.com/ampp…
westonruter Apr 14, 2021
65794bc
Add HeroCandidateFiltering service for injecting attribute via WP fil…
westonruter Apr 14, 2021
01b24b2
Clarify that HeroCandidateFiltering only makes the primary featured i…
westonruter Apr 14, 2021
87472ca
Update phpdoc for DetermineHeroImages
westonruter Apr 14, 2021
2235614
Make test_filter_attachment_image_attributes determinate
westonruter Apr 15, 2021
8bd9855
Fix test_filter_attachment_image_attributes in WP≤5.1
westonruter Apr 15, 2021
e292be3
Add missing entries to PHPSTORM_META
westonruter Apr 15, 2021
09942f9
Combine array_unshift() calls
westonruter Apr 15, 2021
92d7baa
Omit amp-toolbox/.gitattributes from dist
westonruter Apr 15, 2021
334bb46
Remove unnecessary optional chaining and since not available in Node 12
westonruter Apr 15, 2021
67a2f91
Fix add_data_hero_candidate_attribute test
westonruter Apr 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 43 additions & 38 deletions .phpstorm.meta.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,44 +7,49 @@

// TODO: I'd like to use AmpWpPlugin::SERVICES directly here but it doesn't seem to work.
map( [
'admin.analytics_menu' => \AmpProject\AmpWP\Admin\AnalyticsOptionsSubmenu::class,
'admin.google_fonts' => \AmpProject\AmpWP\Admin\GoogleFonts::class,
'admin.onboarding_menu' => \AmpProject\AmpWP\Admin\OnboardingWizardSubmenu::class,
'admin.onboarding_wizard' => \AmpProject\AmpWP\Admin\OnboardingWizardSubmenuPage::class,
'admin.options_menu' => \AmpProject\AmpWP\Admin\OptionsMenu::class,
'admin.polyfills' => \AmpProject\AmpWP\Admin\Polyfills::class,
'admin.paired_browsing' => \AmpProject\AmpWP\Admin\PairedBrowsing::class,
'admin.validation_counts' => \AmpProject\AmpWP\Admin\ValidationCounts::class,
'admin.plugin_row_meta' => \AmpProject\AmpWP\Admin\PluginRowMeta::class,
'amp_slug_customization_watcher' => \AmpProject\AmpWP\AmpSlugCustomizationWatcher::class,
'css_transient_cache.ajax_handler' => \AmpProject\AmpWP\Admin\ReenableCssTransientCachingAjaxAction::class,
'css_transient_cache.monitor' => \AmpProject\AmpWP\BackgroundTask\MonitorCssTransientCaching::class,
'dev_tools.block_sources' => \AmpProject\AmpWP\DevTools\BlockSources::class,
'dev_tools.callback_reflection' => \AmpProject\AmpWP\DevTools\CallbackReflection::class,
'dev_tools.error_page' => \AmpProject\AmpWP\DevTools\ErrorPage::class,
'dev_tools.file_reflection' => \AmpProject\AmpWP\DevTools\FileReflection::class,
'dev_tools.likely_culprit_detector' => \AmpProject\AmpWP\DevTools\LikelyCulpritDetector::class,
'dev_tools.user_access' => \AmpProject\AmpWP\DevTools\UserAccess::class,
'editor.editor_support' => \AmpProject\AmpWP\Editor\EditorSupport::class,
'extra_theme_and_plugin_headers' => \AmpProject\AmpWP\ExtraThemeAndPluginHeaders::class,
'injector' => \AmpProject\AmpWP\Infrastructure\Injector::class,
'mobile_redirection' => \AmpProject\AmpWP\MobileRedirection::class,
'obsolete_block_attribute_remover' => \AmpProject\AmpWP\ObsoleteBlockAttributeRemover::class,
'optimizer' => \AmpProject\AmpWP\Optimizer\OptimizerService::class,
'plugin_activation_notice' => \AmpProject\AmpWP\Admin\PluginActivationNotice::class,
'plugin_registry' => \AmpProject\AmpWP\PluginRegistry::class,
'plugin_suppression' => \AmpProject\AmpWP\PluginSuppression::class,
'reader_theme_loader' => \AmpProject\AmpWP\ReaderThemeLoader::class,
'rest.options_controller' => \AmpProject\AmpWP\OptionsRESTController::class,
'rest.validation_counts_controller' => \AmpProject\AmpWP\Validation\ValidationCountsRestController::class,
'server_timing' => \AmpProject\AmpWP\Instrumentation\ServerTiming::class,
'site_health_integration' => \AmpProject\AmpWP\Admin\SiteHealth::class,
'validated_url_stylesheet_gc' => \AmpProject\AmpWP\BackgroundTask\ValidatedUrlStylesheetDataGarbageCollection::class,
'url_validation_cron' => \AmpProject\AmpWP\Validation\URLValidationCron::class,
'save_post_validation_event' => \AmpProject\AmpWP\Validation\SavePostValidationEvent::class,
'background_task_deactivator' => \AmpProject\AmpWP\BackgroundTask\BackgroundTaskDeactivator::class,
'paired_routing' => \AmpProject\AmpWP\PairedRouting::class,
'paired_url' => \AmpProject\AmpWP\PairedUrl::class,
'admin.analytics_menu' => \AmpProject\AmpWP\Admin\AnalyticsOptionsSubmenu::class,
'admin.google_fonts' => \AmpProject\AmpWP\Admin\GoogleFonts::class,
'admin.onboarding_menu' => \AmpProject\AmpWP\Admin\OnboardingWizardSubmenu::class,
'admin.onboarding_wizard' => \AmpProject\AmpWP\Admin\OnboardingWizardSubmenuPage::class,
'admin.options_menu' => \AmpProject\AmpWP\Admin\OptionsMenu::class,
'admin.polyfills' => \AmpProject\AmpWP\Admin\Polyfills::class,
'admin.paired_browsing' => \AmpProject\AmpWP\Admin\PairedBrowsing::class,
'admin.validation_counts' => \AmpProject\AmpWP\Admin\ValidationCounts::class,
'admin.plugin_row_meta' => \AmpProject\AmpWP\Admin\PluginRowMeta::class,
'amp_slug_customization_watcher' => \AmpProject\AmpWP\AmpSlugCustomizationWatcher::class,
'cli.command_namespace' => \AmpProject\AmpWP\CliCli\CommandNamespaceRegistration::class,
'cli.optimizer_command' => \AmpProject\AmpWP\CliCli\OptimizerCommand::class,
'cli.transformer_command' => \AmpProject\AmpWP\CliCli\TransformerCommand::class,
'cli.validation_command' => \AmpProject\AmpWP\CliCli\ValidationCommand::class,
'css_transient_cache.ajax_handler' => \AmpProject\AmpWP\Admin\ReenableCssTransientCachingAjaxAction::class,
'css_transient_cache.monitor' => \AmpProject\AmpWP\BackgroundTask\MonitorCssTransientCaching::class,
'dev_tools.block_sources' => \AmpProject\AmpWP\DevTools\BlockSources::class,
'dev_tools.callback_reflection' => \AmpProject\AmpWP\DevTools\CallbackReflection::class,
'dev_tools.error_page' => \AmpProject\AmpWP\DevTools\ErrorPage::class,
'dev_tools.file_reflection' => \AmpProject\AmpWP\DevTools\FileReflection::class,
'dev_tools.likely_culprit_detector' => \AmpProject\AmpWP\DevTools\LikelyCulpritDetector::class,
'dev_tools.user_access' => \AmpProject\AmpWP\DevTools\UserAccess::class,
'editor.editor_support' => \AmpProject\AmpWP\Editor\EditorSupport::class,
'extra_theme_and_plugin_headers' => \AmpProject\AmpWP\ExtraThemeAndPluginHeaders::class,
'injector' => \AmpProject\AmpWP\Infrastructure\Injector::class,
'mobile_redirection' => \AmpProject\AmpWP\MobileRedirection::class,
'obsolete_block_attribute_remover' => \AmpProject\AmpWP\ObsoleteBlockAttributeRemover::class,
'optimizer' => \AmpProject\AmpWP\Optimizer\OptimizerService::class,
'optimizer.hero_candidate_filtering' => \AmpProject\AmpWP\Optimizer\HeroCandidateFiltering::class,
'plugin_activation_notice' => \AmpProject\AmpWP\Admin\PluginActivationNotice::class,
'plugin_registry' => \AmpProject\AmpWP\PluginRegistry::class,
'plugin_suppression' => \AmpProject\AmpWP\PluginSuppression::class,
'reader_theme_loader' => \AmpProject\AmpWP\ReaderThemeLoader::class,
'rest.options_controller' => \AmpProject\AmpWP\OptionsRESTController::class,
'rest.validation_counts_controller' => \AmpProject\AmpWP\Validation\ValidationCountsRestController::class,
'server_timing' => \AmpProject\AmpWP\Instrumentation\ServerTiming::class,
'site_health_integration' => \AmpProject\AmpWP\Admin\SiteHealth::class,
'validated_url_stylesheet_gc' => \AmpProject\AmpWP\BackgroundTask\ValidatedUrlStylesheetDataGarbageCollection::class,
'url_validation_cron' => \AmpProject\AmpWP\Validation\URLValidationCron::class,
'save_post_validation_event' => \AmpProject\AmpWP\Validation\SavePostValidationEvent::class,
'background_task_deactivator' => \AmpProject\AmpWP\BackgroundTask\BackgroundTaskDeactivator::class,
'paired_routing' => \AmpProject\AmpWP\PairedRouting::class,
'paired_url' => \AmpProject\AmpWP\PairedUrl::class,
] )
);

Expand Down
3 changes: 2 additions & 1 deletion Gruntfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,9 @@ module.exports = function( grunt ) {
'vendor/*/*/*.yml',
'vendor/*/*/.*.yml',
'vendor/*/*/tests',
'vendor/ampproject/amp-toolbox/bin',
'vendor/ampproject/amp-toolbox/.gitattributes',
'vendor/ampproject/amp-toolbox/.phpcs.xml.dist',
'vendor/ampproject/amp-toolbox/bin',
'vendor/ampproject/amp-toolbox/conceptual-diagram.svg',
'vendor/ampproject/amp-toolbox/phpstan.neon.dist',
'vendor/bin',
Expand Down
Loading