Code

Improve hero image determination#6062

Code

Merged

westonruter merged 22 commits intodevelopampproject/amp-wp:developfrom

fix/hero-image-candidate-determinationampproject/amp-wp:fix/hero-image-candidate-determinationCopy head branch name to clipboard

Apr 15, 2021

Commits

Commits on Apr 11, 2021

• Include DetermineHeroImages on non-core themes as well

  westonruter

  committed
  2e40142

  Copy full SHA for 2e40142

• Improve identification of images in header

  westonruter

  committed
  0521582

  Copy full SHA for 0521582

• Gather custom logo along with other header images

  westonruter

  committed
  9a65ecc

  Copy full SHA for 9a65ecc

• Update tests for DetermineHeroImages

  westonruter

  committed
  f9bff05

  Copy full SHA for f9bff05

• Expand prerendering to any initial block containing an image

  westonruter

  committed
  0549326

  Copy full SHA for 0549326

• Use Element instead of DOMElement

  westonruter

  committed
  f27dab7

  Copy full SHA for f27dab7

• Add test to ensure tiny image at beginning of entry-content is not made hero candidate

  westonruter

  committed
  0ce975a

  Copy full SHA for 0ce975a

• Update amp-toolbox-php to https://github.com/ampproject/amp-toolbox-php/pull/149

  westonruter

  committed
  5100cd4

  Copy full SHA for 5100cd4

Commits on Apr 14, 2021

• Merge branch 'develop' of github.com:ampproject/amp-wp into fix/hero-image-candidate-determination

  Show description for d042d35
  westonruter

  committed
  d042d35

  Copy full SHA for d042d35

• Update amp-toolbox-php to 0.4.0

  westonruter

  committed
  23f1d7b

  Copy full SHA for 23f1d7b

• Merge branch 'develop' of github.com:ampproject/amp-wp into fix/hero-image-candidate-determination

  Show description for 0e8de7f
  westonruter

  committed
  0e8de7f

  Copy full SHA for 0e8de7f

• Update amp-toolbox-php to dev-main to include https://github.com/ampproject/amp-toolbox-php/pull/154

  westonruter

  committed
  08d2e83

  Copy full SHA for 08d2e83

• Add HeroCandidateFiltering service for injecting attribute via WP filters

  westonruter

  committed
  65794bc

  Copy full SHA for 65794bc

• Clarify that HeroCandidateFiltering only makes the primary featured image a hero candidate

  westonruter

  committed
  01b24b2

  Copy full SHA for 01b24b2

• Update phpdoc for DetermineHeroImages

  westonruter

  committed
  87472ca

  Copy full SHA for 87472ca

Commits on Apr 15, 2021

• Make test_filter_attachment_image_attributes determinate

  westonruter

  committed
  2235614

  Copy full SHA for 2235614

• Fix test_filter_attachment_image_attributes in WP≤5.1

  westonruter

  committed
  8bd9855

  Copy full SHA for 8bd9855

• Add missing entries to PHPSTORM_META

  westonruter

  committed
  e292be3

  Copy full SHA for e292be3

• Combine array_unshift() calls

  Show description for 09942f9
  

  westonruter

  and

  pierlon

  authored
  09942f9

  Copy full SHA for 09942f9

• Omit amp-toolbox/.gitattributes from dist

  westonruter

  committed
  92d7baa

  Copy full SHA for 92d7baa

• Remove unnecessary optional chaining and since not available in Node 12

  westonruter

  committed
  334bb46

  Copy full SHA for 334bb46

• Fix add_data_hero_candidate_attribute test

  Show description for 67a2f91
  

  westonruter

  and

  pierlon

  committed
  67a2f91

  Copy full SHA for 67a2f91