refactor: remove-previous-retry-logic #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (10)
- android/src/main/java/com/amplitude/android/storage/AndroidStorageV2.kt: Language not supported
- android/src/main/java/com/amplitude/android/utilities/AndroidStorage.kt: Language not supported
- android/src/test/java/com/amplitude/android/ResponseHandlerTest.kt: Language not supported
- core/src/main/java/com/amplitude/core/platform/EventPipeline.kt: Language not supported
- core/src/main/java/com/amplitude/core/utilities/EventsFileManager.kt: Language not supported
- core/src/main/java/com/amplitude/core/utilities/FileResponseHandler.kt: Language not supported
- core/src/main/java/com/amplitude/core/utilities/FileStorage.kt: Language not supported
- core/src/main/java/com/amplitude/core/utilities/http/AnalyticsResponse.kt: Language not supported
- core/src/main/java/com/amplitude/core/utilities/http/HttpClient.kt: Language not supported
- samples/kotlin-android-app/src/main/java/com/amplitude/android/sample/CustomOkHttpClient.kt: Language not supported
|
Marking as draft, this should be merged together with the updated retry logic. |
polbins
changed the base branch from
main
to
AMP-124458/reformatting-and-warning-fixes
polbins
force-pushed
the
AMP-124458/remove-previous-retry-logic
branch
2 times, most recently
from
4712624 to
43e7f7d
Compare
igor-amp
reviewed
Mar 21, 2025
igor-amp
reviewed
Mar 21, 2025
igor-amp
reviewed
Mar 21, 2025
core/src/main/java/com/amplitude/core/utilities/EventsFileManager.kt
Outdated
Show resolved
Hide resolved
igor-amp
reviewed
Mar 21, 2025
Base automatically changed from
AMP-124458/reformatting-and-warning-fixes
to
main
March 21, 2025 23:25
- see changes original PR at #113 - we're going to update the retry logic in a separate PR
polbins
force-pushed
the
AMP-124458/remove-previous-retry-logic
branch
from
43e7f7d to
6ec357a
Compare
|
🎉 This PR is included in version 1.20.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a pre-requisite change prior to implementing the updated retry logic.
The goal of this PR is to revert the previous logic that doesn't align with the updated one that we want. (e.g. we're not going to modify the flushInterval on EventPipeline, and put most of the retry logic inside the Pipeline itself)
Checklist