Skip to content

Commit 43e7f7d

Browse files
committed
fix failing test
1 parent 7a65df2 commit 43e7f7d

File tree

3 files changed

+13
-5
lines changed

3 files changed

+13
-5
lines changed

android/src/test/java/com/amplitude/android/ResponseHandlerTest.kt

-2
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,11 @@ import org.junit.Assert.assertEquals
2121
import org.junit.Assert.assertNotNull
2222
import org.junit.Assert.assertTrue
2323
import org.junit.Before
24-
import org.junit.Ignore
2524
import org.junit.Test
2625
import org.junit.runner.RunWith
2726
import org.robolectric.RobolectricTestRunner
2827
import java.util.concurrent.TimeUnit
2928

30-
@Ignore
3129
@RunWith(RobolectricTestRunner::class)
3230
class ResponseHandlerTest {
3331
private lateinit var server: MockWebServer

core/src/main/java/com/amplitude/core/Amplitude.kt

+2-2
Original file line numberDiff line numberDiff line change
@@ -156,10 +156,10 @@ open class Amplitude internal constructor(
156156
options: EventOptions? = null,
157157
callback: EventCallBack? = null,
158158
): Amplitude {
159-
options ?. let {
159+
options?.let {
160160
event.mergeEventOptions(it)
161161
}
162-
callback ?. let {
162+
callback?.let {
163163
event.callback = it
164164
}
165165
process(event)

core/src/main/java/com/amplitude/core/platform/EventPipeline.kt

+11-1
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,15 @@ class EventPipeline(
3030
private var scheduled: Boolean
3131
var flushSizeDivider: AtomicInteger = AtomicInteger(1)
3232

33+
private val responseHandler by lazy {
34+
storage.getResponseHandler(
35+
this@EventPipeline,
36+
amplitude.configuration,
37+
scope,
38+
amplitude.retryDispatcher,
39+
)
40+
}
41+
3342
companion object {
3443
internal const val UPLOAD_SIG = "#!upload"
3544
}
@@ -116,7 +125,8 @@ class EventPipeline(
116125
if (eventsString.isEmpty()) continue
117126

118127
val diagnostics = amplitude.diagnostics.extractDiagnostics()
119-
httpClient.upload(eventsString, diagnostics)
128+
val response = httpClient.upload(eventsString, diagnostics)
129+
responseHandler.handle(response, events, eventsString)
120130
} catch (e: FileNotFoundException) {
121131
e.message?.let {
122132
amplitude.logger.warn("Event storage file not found: $it")

0 commit comments

Comments
 (0)