fix: retry upload order #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polbins
force-pushed
the
AMP-124458/fix-retry-upload-order
branch
from
bc600a7 to
5fcee0a
Compare
polbins
commented
Mar 22, 2025
polbins
force-pushed
the
AMP-124458/remove-previous-retry-logic
branch
from
43e7f7d to
6ec357a
Compare
1 task
polbins
force-pushed
the
AMP-124458/fix-retry-upload-order
branch
4 times, most recently
from
bfad97e to
3e3ad04
Compare
igor-amp
reviewed
Mar 25, 2025
polbins
force-pushed
the
AMP-124458/fix-retry-upload-order
branch
from
3e3ad04 to
e893149
Compare
igor-amp
reviewed
Mar 26, 2025
igor-amp
reviewed
Mar 26, 2025
core/src/main/java/com/amplitude/core/platform/EventPipeline.kt
Outdated
Show resolved
Hide resolved
polbins
force-pushed
the
AMP-124458/fix-retry-upload-order
branch
from
e893149 to
a34ce24
Compare
igor-amp
requested changes
Mar 26, 2025
polbins
force-pushed
the
AMP-124458/fix-retry-upload-order
branch
from
a34ce24 to
498a4f0
Compare
polbins
force-pushed
the
AMP-124458/fix-retry-upload-order
branch
4 times, most recently
from
63c8002 to
1cc8aa1
Compare
igor-amp
reviewed
Apr 1, 2025
igor-amp
reviewed
Apr 1, 2025
igor-amp
reviewed
Apr 1, 2025
igor-amp
reviewed
Apr 1, 2025
core/src/test/kotlin/com/amplitude/core/platform/EventPipelineTest.kt
Outdated
Show resolved
Hide resolved
igor-amp
reviewed
Apr 1, 2025
…iled - this new logic will respect the order of files as it will always get the next file that we need to upload
- uses ExponentialBackoffRetryHandler to handle most of the logic
This reverts commit 8a4defe.
polbins
force-pushed
the
AMP-124458/fix-retry-upload-order
branch
from
a9a46ac to
445aadb
Compare
|
🎉 This PR is included in version 1.20.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After removal of the old retry logic in #258, we're now re-introducing an updated version of retrying in this PR.
We have an updated
AnalyticsResponsewith a flag to retry when upload failed. The premise is that we will retry when the event file is still present, and won't retry if it's not (e.g. bad event file).After knowing the result of the response, we'll now retry within the
EventPipelineitself through the use ofExponentialBackoffRetryHandler. This class contains the logic for exponential back-off delay that happens every retry attempt.We've also updated how we're reading the event file from storage. We'll get the sorted event files again, whenever we're retrying.
Checklist