This repository was archived by the owner on Dec 16, 2022. It is now read-only.
Turn off shuffling during evaluation #1578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelgrus
approved these changes
Aug 6, 2018
gabrielStanovsky
pushed a commit
to gabrielStanovsky/allennlp
that referenced
this pull request
Sep 7, 2018
|
@nelson-liu I keep getting this warning during validation evaluation after each epoch training. Since shuffling for validation has been explicitly turned off, should warning for validation iterator be turned off ? |
|
I don't have a strong opinion either way, but you're right that the message isn't too useful now that validation shuffle is always false. |
|
I think it's probably fine to move that warning to a comment in the code. |
|
@matt-gardner That would cause the warning to not show for train iterator as well. Would that be fine? |
|
I think so. The probability of running into the issue that's being warned about is incredibly small, so we should optimize for the much more common case. |
HarshTrivedi
added a commit
to HarshTrivedi/allennlp
that referenced
this pull request
Sep 10, 2018
From discussion here: allenai#1578. Let me know if I should remove the code instead of commenting it.
matt-gardner
pushed a commit
that referenced
this pull request
Sep 10, 2018
* Remove bucket iterator shuffle warning. From discussion here: #1578. Let me know if I should remove the code instead of commenting it. * Remove the warning and add comment instead. * Add a period.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.