Turn off shuffling during evaluation (#1578)

Author: nelson-liu

allennlp/commands/evaluate.py

@@ -94,7 +94,10 @@ def evaluate(model: Model,
     with torch.no_grad():
         model.eval()
 
-        iterator = data_iterator(instances, num_epochs=1, cuda_device=cuda_device)
+        iterator = data_iterator(instances,
+                                 num_epochs=1,
+                                 shuffle=False,
+                                 cuda_device=cuda_device)
         logger.info("Iterating over dataset")
         generator_tqdm = Tqdm.tqdm(iterator, total=data_iterator.get_num_batches(instances))
         for batch in generator_tqdm:

allennlp/training/trainer.py

@@ -667,7 +667,7 @@ def _validation_loss(self) -> Tuple[float, int]:
 
         val_generator = val_iterator(self._validation_data,
                                      num_epochs=1,
-                                     shuffle=self._shuffle,
+                                     shuffle=False,
                                      cuda_device=self._iterator_device)
         num_validation_batches = val_iterator.get_num_batches(self._validation_data)
         val_generator_tqdm = Tqdm.tqdm(val_generator,