Skip to content

[CS0618][Stage] Warning Disable #6676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2023
Merged

[CS0618][Stage] Warning Disable #6676

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bad7c53
[CS0618][Stage] Warning Disable
eaba Apr 25, 2023
901f09b
Merge branch 'dev' into Stage
eaba Apr 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/core/Akka.Streams/Implementation/Stages/Stages.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,9 @@ public SymbolicGraphStage(ISymbolicStage<TIn, TOut> symbolicStage) : base(symbol
/// </summary>
/// <typeparam name="TIn">TBD</typeparam>
/// <typeparam name="TOut">TBD</typeparam>
#pragma warning disable CS0618 // Type or member is obsolete
public interface ISymbolicStage<in TIn, out TOut> : IStage<TIn, TOut>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it IStage that is obsolete? Any reason why it was marked as Obsolete (in the Reason field?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

akka.net/src/core/Akka.Streams/Stage/Stage.cs

Lines 33 to 36 in b688e5c

/// <typeparam name="TOut">TBD</typeparam>
[Obsolete("Please use GraphStage instead. [1.1.0]")]
public interface IStage<in TIn, out TOut> { }

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eaba so let's use GraphStage instead of IStage, rather than disable the warning.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I think I see what the issue is here - this is an interface not a class - therefore it can't be fixed via inheriting from GraphStage, got it.

#pragma warning restore CS0618 // Type or member is obsolete
{
/// <summary>
/// TBD
Expand All @@ -491,7 +493,9 @@ public interface ISymbolicStage<in TIn, out TOut> : IStage<TIn, TOut>
/// </summary>
/// <param name="effectiveAttributes">TBD</param>
/// <returns>TBD</returns>
#pragma warning disable CS0618 // Type or member is obsolete
IStage<TIn, TOut> Create(Attributes effectiveAttributes);
#pragma warning restore CS0618 // Type or member is obsolete
}

/// <summary>
Expand Down Expand Up @@ -520,7 +524,9 @@ protected SymbolicStage(Attributes attributes)
/// </summary>
/// <param name="effectiveAttributes">TBD</param>
/// <returns>TBD</returns>
#pragma warning disable CS0618 // Type or member is obsolete
public abstract IStage<TIn, TOut> Create(Attributes effectiveAttributes);
#pragma warning restore CS0618 // Type or member is obsolete

/// <summary>
/// TBD
Expand Down