-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[CS0618][Stage] Warning Disable #6676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a question
@@ -479,7 +479,9 @@ public SymbolicGraphStage(ISymbolicStage<TIn, TOut> symbolicStage) : base(symbol | |||
/// </summary> | |||
/// <typeparam name="TIn">TBD</typeparam> | |||
/// <typeparam name="TOut">TBD</typeparam> | |||
#pragma warning disable CS0618 // Type or member is obsolete | |||
public interface ISymbolicStage<in TIn, out TOut> : IStage<TIn, TOut> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it IStage
that is obsolete? Any reason why it was marked as Obsolete (in the Reason
field?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
akka.net/src/core/Akka.Streams/Stage/Stage.cs
Lines 33 to 36 in b688e5c
/// <typeparam name="TOut">TBD</typeparam> | |
[Obsolete("Please use GraphStage instead. [1.1.0]")] | |
public interface IStage<in TIn, out TOut> { } | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eaba so let's use GraphStage
instead of IStage
, rather than disable the warning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I think I see what the issue is here - this is an interface not a class - therefore it can't be fixed via inheriting from GraphStage, got it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to follow the warning's advice rather than disable it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -479,7 +479,9 @@ public SymbolicGraphStage(ISymbolicStage<TIn, TOut> symbolicStage) : base(symbol | |||
/// </summary> | |||
/// <typeparam name="TIn">TBD</typeparam> | |||
/// <typeparam name="TOut">TBD</typeparam> | |||
#pragma warning disable CS0618 // Type or member is obsolete | |||
public interface ISymbolicStage<in TIn, out TOut> : IStage<TIn, TOut> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I think I see what the issue is here - this is an interface not a class - therefore it can't be fixed via inheriting from GraphStage, got it.
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):