Skip to content

[Obsolete] RunScript #6623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 27, 2023
Merged

[Obsolete] RunScript #6623

merged 7 commits into from
Mar 27, 2023

Conversation

eaba
Copy link
Contributor

@eaba eaba commented Mar 27, 2023

Changes

  • Change RunScript to RunScriptAsync

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

@eaba eaba marked this pull request as draft March 27, 2023 13:53
eaba and others added 5 commits March 27, 2023 15:28
@eaba
fixes
8040a38
@eaba
Merge branch 'dev' into obsolete_run-script
fb4e1ec
@eaba
more fix: Change RandomTestRange(Sys).ForEach to RandomTestRange(S…
ff1c37b 
…ys).Select`
@eaba
Merge
6436dbd
@Aaronontheweb @eaba
skip racy TickSourceSpec (#6566)
fd243c6 
this spec is designed just fine, but the problem is that we can't guarantee this level of precision for each of the `ExpectNoMsg` calls.
@eaba eaba marked this pull request as ready for review March 27, 2023 15:38
Aaronontheweb
Aaronontheweb approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) March 27, 2023 21:32
@Aaronontheweb Aaronontheweb merged commit 5da08f7 into akkadotnet:dev Mar 27, 2023
@eaba eaba deleted the obsolete_run-script branch March 28, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eaba @Aaronontheweb