[Obsolete] RunScript (#6623)

* [Obsolete] `RunScript`

* fixes

* more fix: Change ` RandomTestRange(Sys).ForEach` to RandomTestRange(Sys).Select`

* skip racy `TickSourceSpec` (#6566)

this spec is designed just fine, but the problem is that we can't guarantee this level of precision for each of the `ExpectNoMsg` calls.

---------

Co-authored-by: Aaron Stannard <[email protected]>

Author: eaba

src/core/Akka.Streams.Tests/Dsl/FlowGroupedWithinSpec.cs

@@ -232,7 +232,7 @@ public void A_GroupedWithin_must_group_early()
                 }).ToArray());
 
             RandomTestRange(Sys)
-                .ForEach(_ => RunScript(script, Settings, flow => flow.GroupedWithin(3, TimeSpan.FromMinutes(10))));
+                .Select(async _ => await RunScriptAsync(script, Settings, flow => flow.GroupedWithin(3, TimeSpan.FromMinutes(10))));
         }
 
         [Fact]
@@ -255,7 +255,7 @@ public void A_GroupedWithin_must_group_with_rest()
             };
 
             RandomTestRange(Sys)
-                .ForEach(_ => RunScript(script(), Settings, flow => flow.GroupedWithin(3, TimeSpan.FromMinutes(10))));
+                .Select(async _ => await RunScriptAsync(script(), Settings, flow => flow.GroupedWithin(3, TimeSpan.FromMinutes(10))));
         }
 
         [Fact(Skip = "Skipped for async_testkit conversion build")]

src/core/Akka.Streams.Tests/Dsl/FlowSelectManySpec.cs

@@ -9,6 +9,7 @@
 using System.Collections.Generic;
 using System.Linq;
 using System.Threading;
+using System.Threading.Tasks;
 using Akka.Streams.Dsl;
 using Akka.Streams.Supervision;
 using Akka.Streams.TestKit;
@@ -31,7 +32,7 @@ public FlowSelectManySpec(ITestOutputHelper output) : base(output)
         }
 
         [Fact]
-        public void SelectMany_should_map_and_concat()
+        public async Task SelectMany_should_map_and_concat()
         {
             var script = Script.Create(
                 (new[] { 0 }, new int[0]),
@@ -43,7 +44,7 @@ public void SelectMany_should_map_and_concat()
 
             var random = ThreadLocalRandom.Current.Next(1, 10);
             for (int i = 0; i < random; i++)
-                RunScript(script, Settings, a => a.SelectMany(x => Enumerable.Range(1, x).Select(_ => x)));
+                await RunScriptAsync(script, Settings, a => a.SelectMany(x => Enumerable.Range(1, x).Select(_ => x)));
         }
 
         [Fact]

src/core/Akka.Streams.Tests/Dsl/FlowSelectSpec.cs

@@ -8,6 +8,7 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
+using System.Threading.Tasks;
 using Akka.Streams.Dsl;
 using Akka.Streams.TestKit;
 using Akka.Util;
@@ -31,7 +32,7 @@ public FlowSelectSpec(ITestOutputHelper output) : base(output)
         }
 
         [Fact]
-        public void Select_should_select()
+        public async Task Select_should_select()
         {
 
             var script = Script.Create(Enumerable.Range(1, ThreadLocalRandom.Current.Next(1, 10)).Select(_ =>
@@ -43,7 +44,7 @@ public void Select_should_select()
             var n = ThreadLocalRandom.Current.Next(10);
             for (int i = 0; i < n; i++)
             {
-                RunScript(script, _settings, x => x.Select(y => y.ToString()));
+                await RunScriptAsync(script, _settings, x => x.Select(y => y.ToString()));
             }
         }
 

src/core/Akka.Streams.Tests/Dsl/FlowSkipSpec.cs

@@ -8,6 +8,7 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
+using System.Threading.Tasks;
 using Akka.Streams.Dsl;
 using Akka.Streams.TestKit;
 using Xunit;
@@ -28,7 +29,7 @@ public FlowSkipSpec(ITestOutputHelper helper) : base(helper)
         }
 
         [Fact]
-        public void A_Skip_must_skip()
+        public async Task A_Skip_must_skip()
         {
             Func<long, Script<int, int>> script =
                 d => Script.Create(RandomTestRange(Sys)
@@ -38,7 +39,7 @@ public void A_Skip_must_skip()
             foreach (var _ in RandomTestRange(Sys))
             {
                 var d = Math.Min(Math.Max(random.Next(-10, 60), 0), 50);
-                RunScript(script(d), Settings, f => f.Skip(d));
+                await RunScriptAsync(script(d), Settings, f => f.Skip(d));
             }
         }
 

src/core/Akka.Streams.Tests/Dsl/FlowStatefulSelectManySpec.cs

@@ -45,9 +45,9 @@ public void A_StatefulSelectMany_must_work_in_happy_case()
                 return Script.Create(phases);
             };
 
-            RandomTestRange(Sys).ForEach(_ =>
+            RandomTestRange(Sys).Select(async _ =>
             {
-                RunScript(script(), Materializer.Settings, flow => flow.StatefulSelectMany<int,int,int, NotUsed>(() =>
+                await RunScriptAsync(script(), Materializer.Settings, flow => flow.StatefulSelectMany<int,int,int, NotUsed>(() =>
                 {
                     int? prev = null;
                     return (x =>

src/core/Akka.Streams.Tests/Dsl/FlowTakeSpec.cs

@@ -8,6 +8,7 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
+using System.Threading.Tasks;
 using Akka.Streams.Actors;
 using Akka.Streams.Dsl;
 using Akka.Streams.Implementation;
@@ -38,10 +39,10 @@ public void A_Take_must_take()
             Func<int, Script<int, int>> script =
                 d => Script.Create(RandomTestRange(Sys).Select(n => ((ICollection<int>)new[] { n }, (ICollection<int>)(n > d ? new int[]{ } : new[] { n }))).ToArray());
             var random = new Random();
-            RandomTestRange(Sys).ForEach(_ =>
+            RandomTestRange(Sys).Select(async _ =>
             {
                 var d = Math.Min(Math.Max(random.Next(-10, 60), 0), 50);
-                RunScript(script(d), Materializer.Settings, f => f.Take(d));
+                await RunScriptAsync(script(d), Materializer.Settings, f => f.Take(d));
             });
         }
 

src/core/Akka.Streams.Tests/Dsl/FlowWhereSpec.cs

@@ -42,7 +42,7 @@ public void A_Where_must_filter()
                 return ((ICollection<int>)new[] { x }, (ICollection<int>)((x & 1) == 0 ? new[] { x } : new int[] { }));
             }).ToArray());
 
-            RandomTestRange(Sys).ForEach(_ => RunScript(script, Settings, flow => flow.Where(x => x%2 == 0)));
+            RandomTestRange(Sys).Select(async _ => await RunScriptAsync(script, Settings, flow => flow.Where(x => x%2 == 0)));
         }
 
         [Fact]
@@ -96,7 +96,7 @@ public void A_WhereNot_must_filter_based_on_inverted_predicate()
                 return ((ICollection<int>)new[] { x }, (ICollection<int>)((x & 1) == 1 ? new[] { x } : new int[] { }));
             }).ToArray());
 
-            RandomTestRange(Sys).ForEach(_ => RunScript(script, Settings, flow => flow.WhereNot(x => x % 2 == 0)));
+            RandomTestRange(Sys).Select(async _ => await RunScriptAsync(script, Settings, flow => flow.WhereNot(x => x % 2 == 0)));
         }
     }
 }