Skip to content

update code-checkers config #9707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2022
Merged

update code-checkers config #9707

merged 1 commit into from
Feb 10, 2022

Conversation

sergei-solonitcyn
Copy link
Contributor

@sergei-solonitcyn sergei-solonitcyn commented Jan 21, 2022

Signed-off-by: Sergei Solonitcyn [email protected]

What

Connectors' code quality tools used by invoke commands required some improvements:

  • all-checks tasks run only first task in its list
  • mypy missed stubs
  • mypy used cache, but it's not desirable for our purposes
  • mypy didn't use implicit reexport
  • several sequenced tasks in all-checks or coverage weren't splitted in any way

How

  • Run all-checks tasks inside try-except blocks, as it's done in coverage
  • Add a command for installing mypy stubs
  • Update mypy config section

fix `all-checks` command

Signed-off-by: Sergei Solonitcyn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

all-checks task for invoke doesn't run all tasks
2 participants