Skip to content

[EPIC] Update connectors' code quality to make it pass all the checks #10174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
11 of 19 tasks
sergei-solonitcyn opened this issue Feb 8, 2022 · 3 comments
Closed
11 of 19 tasks
Labels

Comments

@sergei-solonitcyn
Copy link
Contributor

sergei-solonitcyn commented Feb 8, 2022

We now have a configured tool to run some automatic checks of code quality. It can be run with invoke command from airbyte-integrations/connectors/ directory. See its inline help.
The purpose of this epic is to have all the checks to be passed for every connector. So invoke all-checks -c <connector_name> has to return zero exit code.
In case we found any difference between configurations of this tool and pre_commit, that has to be solved before.

Subtasks:

@sergei-solonitcyn sergei-solonitcyn added type/enhancement New feature or request area/connectors Connector related issues Epic labels Feb 8, 2022
@sergei-solonitcyn sergei-solonitcyn added this to the Connectors Feb 11 milestone Feb 8, 2022
@noahkawasakigoogle
Copy link
Contributor

When you say "checks of code quality" do you mean linters?

@sergei-solonitcyn
Copy link
Contributor Author

Yes, linters, tests and test coverage

@sergei-solonitcyn
Copy link
Contributor Author

sergei-solonitcyn commented Feb 10, 2022

This PR is required to be merged before:
#9707

UPD: above PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants