Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

live-test: improve error message when the selected connection did not run the control version #45335

Merged
merged 1 commit into from
Sep 10, 2024
Merged

live-test: improve error message when the selected connection did not run the control version #45335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions airbyte-ci/connectors/live-tests/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,11 @@ The traffic recorded on the control connector is passed to the target connector

## Changelog

### 0.18.8

Improve error message when failing to retrieve connection.
Ask to double-check that a sync ran with the control version on the selected connection.

### 0.18.7

Improve error message when failing to retrieve connection.
Expand Down
2 changes: 1 addition & 1 deletion airbyte-ci/connectors/live-tests/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ build-backend = "poetry.core.masonry.api"

[tool.poetry]
name = "live-tests"
version = "0.18.7"
version = "0.18.8"
description = "Contains utilities for testing connectors against live data."
authors = ["Airbyte <[email protected]>"]
license = "MIT"
Expand Down
2 changes: 1 addition & 1 deletion airbyte-ci/connectors/live-tests/src/live_tests/commons/connection_objects_retrieval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ def _get_connection_objects_from_retrieved_objects(
)
elif retrieved_source_docker_image.split(":")[1] != source_docker_image_tag:
raise InvalidConnectionError(
f"The provided docker image tag ({source_docker_image_tag}) does not match the image tag for connection ID {connection_id}. Please double check that this connection is using the correct image tag. Connection URL: {connection_url}"
f"The provided docker image tag ({source_docker_image_tag}) does not match the image tag for connection ID {connection_id}. Please double check that this connection is using the correct image tag and the latest job ran using this version. Connection URL: {connection_url}"
)

return ConnectionObjects(
Expand Down
Loading