live-test: improve error message when the selected connection did not run the control version #45335
Conversation
… run the control version
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alafanechere and the rest of your teammates on |
|
I haven't had time to articulate this well. But I'm convinced that it's not just about the error message that needs improvement. Our users sometimes don't care if the connection ran the last published version, they just need to verify that live outputs on last published version are co distant with target version. Especially if they did not even choose that connection (auto). It's good to merge a better error message, but that should just not happen. We should pick a connection that actually ran latest (isn't that why we have connection retriever in the first place?), and if a good connection otherwise did not run it before but there were no breaking changes between what it ran and control, just run the tests. |
alafanechere
deleted the
augustin/09-09-live-test_improve_error_message_when_the_selected_connection_did_not_run_the_control_version
branch
What
The connection retriever fetches connection matching the control version passed by the user.
When the selected connection did not run a job with the control version we raises an
InvalidConnectionError.Even if the connection is correctly using the control version the connection might not have run a sync on it yet.
Which causes the error.
The constraint of having the latest job on the control version exists to be sure we run our test suite on not connections which are not pinning a version.