-
Notifications
You must be signed in to change notification settings - Fork 4.6k
chore(source-s3): Update CDK to v5 (old) #45199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 4 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
2599427
Source S3: bump version
artem1205 c701306
Source S3: migrate serializers
artem1205 93a8da4
Source S3: bump docs
artem1205 c526535
chore: apply spec changes from generated spec (`poetry run source-s3 …
aaronsteers 8f6f583
chore: auto-fix lint and format issues
octavia-squidington-iii 04336a6
Merge branch 'master' into aj/source-s3-update-cdk-5
aaronsteers a9add41
`poetry lock`
aaronsteers 1a557a1
chore(tests): import `test_acceptance.py` from other S3 PR
aaronsteers 37ad8d2
Update airbyte-integrations/connectors/source-s3/integration_tests/te…
aaronsteers 60efd18
chore: copy `spec.json` to `cloud_spec.json`
aaronsteers f172c6c
Apply suggestions from code review
aaronsteers 28e3a3c
chore: auto-fix lint and format issues
octavia-squidington-iii a9f656c
Merge remote-tracking branch 'origin/master' into aj/source-s3-update…
aaronsteers 4bc8839
`poetry lock`
aaronsteers 4f8eb9d
chore: add back changelog
aaronsteers 57140b1
update acceptance test pytest for invalid_config
aaronsteers 7781b19
update docstring, rename file from test_acceptance.py to test_integra…
aaronsteers File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
860 changes: 518 additions & 342 deletions
860
airbyte-integrations/connectors/source-s3/poetry.lock
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ requires = [ "poetry-core>=1.0.0",] | |
build-backend = "poetry.core.masonry.api" | ||
|
||
[tool.poetry] | ||
version = "4.8.0" | ||
version = "4.9.0" | ||
name = "source-s3" | ||
description = "Source implementation for S3." | ||
authors = [ "Airbyte <[email protected]>",] | ||
|
@@ -23,7 +23,7 @@ python-snappy = "==0.6.1" | |
dill = "==0.3.4" | ||
transformers = "4.38.2" | ||
urllib3 = "<2" | ||
airbyte-cdk = {extras = ["file-based"], version = "^3"} | ||
airbyte-cdk = {extras = ["file-based"], version = "^5"} | ||
|
||
[tool.poetry.scripts] | ||
source-s3 = "source_s3.run:run" | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,12 +3,13 @@ | |
# | ||
|
||
import sys | ||
import time | ||
import traceback | ||
from datetime import datetime | ||
from typing import List | ||
|
||
from airbyte_cdk import AirbyteEntrypoint, AirbyteMessage, Type, launch | ||
from airbyte_cdk.models import AirbyteErrorTraceMessage, AirbyteTraceMessage, TraceType | ||
from airbyte_cdk.models import AirbyteErrorTraceMessage, AirbyteMessageSerializer, AirbyteTraceMessage, TraceType | ||
from orjson import orjson | ||
from source_s3.v4 import Config, Cursor, SourceS3, SourceS3StreamReader | ||
|
||
|
||
|
@@ -27,17 +28,21 @@ def get_source(args: List[str]): | |
) | ||
except Exception: | ||
print( | ||
AirbyteMessage( | ||
type=Type.TRACE, | ||
trace=AirbyteTraceMessage( | ||
type=TraceType.ERROR, | ||
emitted_at=int(datetime.now().timestamp() * 1000), | ||
error=AirbyteErrorTraceMessage( | ||
message="Error starting the sync. This could be due to an invalid configuration or catalog. Please contact Support for assistance.", | ||
stack_trace=traceback.format_exc(), | ||
), | ||
), | ||
).json() | ||
orjson.dumps( | ||
AirbyteMessageSerializer.dump( | ||
AirbyteMessage( | ||
type=Type.TRACE, | ||
trace=AirbyteTraceMessage( | ||
type=TraceType.ERROR, | ||
emitted_at=time.time_ns() // 1_000_000, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. good catch! |
||
error=AirbyteErrorTraceMessage( | ||
message="Error starting the sync. This could be due to an invalid configuration or catalog. Please contact Support for assistance.", | ||
stack_trace=traceback.format_exc(), | ||
), | ||
), | ||
) | ||
) | ||
).decode() | ||
) | ||
return None | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.