chore(source-s3): Update CDK to v5 (old) #45199
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Inzhyyants <[email protected]>
[skip ci] Signed-off-by: Artem Inzhyyants <[email protected]>
Signed-off-by: Artem Inzhyyants <[email protected]>
…spec | jq .spec`)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
octavia-squidington-iii
added
area/connectors
aaronsteers
commented
Sep 6, 2024
airbyte-integrations/connectors/source-s3/integration_tests/spec.json
Outdated
Show resolved
Hide resolved
|
/format-fix
|
aaronsteers
commented
Sep 6, 2024
airbyte-integrations/connectors/source-s3/integration_tests/test_acceptance.py
Outdated
Show resolved
Hide resolved
|
/format-fix
|
aaronsteers
commented
Sep 6, 2024
airbyte-integrations/connectors/source-s3/integration_tests/cloud_spec.json
Outdated
Show resolved
Hide resolved
aaronsteers
commented
Sep 6, 2024
airbyte-integrations/connectors/source-s3/integration_tests/cloud_spec.json
Outdated
Show resolved
Hide resolved
|
/format-fix
|
octavia-squidington-iii
removed
the
area/documentation
octavia-squidington-iii
added
the
area/documentation
|
/approve-regression-tests
|
girarda
approved these changes
Sep 10, 2024
| type=Type.TRACE, | ||
| trace=AirbyteTraceMessage( | ||
| type=TraceType.ERROR, | ||
| emitted_at=time.time_ns() // 1_000_000, |
|
@aaronsteers is this abandoned in favor of the other one? Should we close this? |
|
@natikgadzhi Re:
Yes. There's still some code here I eventually plan to recycle, but the new effort is here: |
aaronsteers
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces:
This bumps the CDK version so we can take advantage of performance boosts in latest CDK.
I spun this out from @artem1205's PR above in order to resolve some CAT failures.
I've imported
integration_tests/test_acceptance.pyfrom the S3 Polars PR. And I added another second test, which asserts that the invalid config json fails as expected.