Skip to content

doc: app-name is now called appName #44882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2024
Merged

doc: app-name is now called appName #44882

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/enterprise-setup/implementation-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,8 +233,8 @@ auth:
secretName: airbyte-config-secrets ## Name of your Kubernetes secret.
oidc:
domain: ## e.g. company.example
app-name: ## e.g. airbyte
display-name: ## e.g. Company SSO - optional, falls back to app-name if not provided
appName: ## e.g. airbyte
display-name: ## e.g. Company SSO - optional, falls back to appName if not provided
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should confirm that the casing for display-name also hasn't changed (I actually don't recognize this field so we must have recently started documenting it

Copy link
Contributor Author

@malikdiarra malikdiarra Aug 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a look yesterday and could not find any reference to either display-name or displayName , I'm not even sure we are doing anything with that field.
We could possibly remove it

clientIdSecretKey: client-id
clientSecretSecretKey: client-secret
```
Expand Down Expand Up @@ -265,8 +265,8 @@ global:
secretName: airbyte-config-secrets ## Name of your Kubernetes secret.
oidc:
domain: ## e.g. company.example
app-name: ## e.g. airbyte
display-name: ## e.g. Company SSO - optional, falls back to app-name if not provided
appName: ## e.g. airbyte
display-name: ## e.g. Company SSO - optional, falls back to appName if not provided
clientIdSecretKey: client-id
clientSecretSecretKey: client-secret
```
Expand Down
Loading