doc: app-name is now called appName #44882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
the
area/documentation
perangel
reviewed
Aug 29, 2024
| app-name: ## e.g. airbyte | ||
| display-name: ## e.g. Company SSO - optional, falls back to app-name if not provided | ||
| appName: ## e.g. airbyte | ||
| display-name: ## e.g. Company SSO - optional, falls back to appName if not provided |
There was a problem hiding this comment.
We should confirm that the casing for display-name also hasn't changed (I actually don't recognize this field so we must have recently started documenting it
There was a problem hiding this comment.
I took a look yesterday and could not find any reference to either display-name or displayName , I'm not even sure we are doing anything with that field.
We could possibly remove it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix enterprise SSO setup documentation
How
Remove reference to an
app-nameconfiguration key, it is not calledappName