Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename registries to registryOverrides in connector metadata #43757

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Rename registries to registryOverrides in connector metadata #43757

merged 1 commit into from
Aug 13, 2024

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Aug 12, 2024 •
edited
Loading

What

Rename registries to registryOverrides in connector metadata.yaml.
Skipping CI to not trigger tests on all connectors

Manual testing on destination-postgres: https://github.com/airbytehq/airbyte/actions/runs/10353121102

@vercel Vercel
Copy link

vercel bot commented Aug 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Aug 13, 2024 2:10pm

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Aug 12, 2024
@alafanechere alafanechere mentioned this pull request Aug 12, 2024
Merged
@alafanechere Graphite App
Copy link
Contributor Author

alafanechere commented Aug 12, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alafanechere and the rest of your teammates on Graphite Graphite

@alafanechere alafanechere force-pushed the augustin/registry-overrides branch from d1a6142 to 63fd362 Compare August 12, 2024 13:40
@alafanechere alafanechere marked this pull request as ready for review August 12, 2024 13:46
@alafanechere alafanechere requested review from a team as code owners August 12, 2024 13:46
@alafanechere alafanechere requested a review from a team August 12, 2024 13:46
@alafanechere alafanechere requested a review from a team as a code owner August 12, 2024 13:46
edgao
edgao approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

connector changes look legit (just find+replace)

just to doublecheck (I didn't read the previous PR in the stack) - are there any backwards-compat things to solve? I.e. will old connector metadata continue working, does anything need to be modified in platform, etc

@octavia-squidington-iv octavia-squidington-iv requested a review from a team August 12, 2024 16:11
@alafanechere
Copy link
Contributor Author

connector changes look legit (just find+replace)

just to doublecheck (I didn't read the previous PR in the stack) - are there any backwards-compat things to solve? I.e. will old connector metadata continue working, does anything need to be modified in platform, etc

@edgao the upstream PR should be merged first and will rename the fields where it's actually used for registry generation. This override logic happens at connector registry generation, so the platform is not aware of these fields.

will old connector metadata continue working
No they won't, this is why I made this PR.

Base automatically changed from augustin/registry-overrides to master August 13, 2024 14:09
@alafanechere alafanechere force-pushed the augustin/08-12-_skip_ci_rename_registries_to_registryOverrides_in_connector_metadata branch from 8f0a6af to 9521bfb Compare August 13, 2024 14:10
@alafanechere alafanechere merged commit 601c3c4 into master Aug 13, 2024
11 of 12 checks passed
@alafanechere alafanechere deleted the augustin/08-12-_skip_ci_rename_registries_to_registryOverrides_in_connector_metadata branch August 13, 2024 14:10
LouisAuneau pushed a commit to LouisAuneau/airbyte that referenced this pull request Aug 13, 2024
@alafanechere @LouisAuneau
Rename registries to registryOverrides in connector metadata (airbyte…
cda66a1 
…hq#43757)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgao edgao edgao approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alafanechere @edgao @octavia-squidington-iii