Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metadata-service: rename registries to registryOverrides #43754

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Aug 12, 2024

What

Closes https://github.com/airbytehq/airbyte-internal-issues/issues/8997
We want to rename the registries metadata field to registryOverrides.
This is to make this field's role more explicit for connector version pinning on Airbyte OSS or Cloud.

Connector specific renaming is in #43757

Copy link

vercel bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Aug 12, 2024 2:22pm

Copy link
Contributor Author

alafanechere commented Aug 12, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alafanechere and the rest of your teammates on Graphite Graphite

@alafanechere alafanechere force-pushed the augustin/registry-overrides branch from d1a6142 to 63fd362 Compare August 12, 2024 13:40
@alafanechere alafanechere marked this pull request as ready for review August 12, 2024 13:42
@alafanechere alafanechere requested review from a team, natikgadzhi and clnoll August 12, 2024 13:42
Copy link
Contributor

@clnoll clnoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Did some grepping and didn't see any other places that needed to be changed.

@alafanechere alafanechere merged commit c0e6489 into master Aug 13, 2024
36 checks passed
@alafanechere alafanechere deleted the augustin/registry-overrides branch August 13, 2024 14:09
LouisAuneau pushed a commit to LouisAuneau/airbyte that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants