feat(connectors-qa): support manifest-only connectors #43377
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
the
area/documentation
|
/format-fix
|
| @@ -63,6 +63,24 @@ def _run(self, connector: Connector) -> CheckResult: | |||
| return self.create_check_result(connector=connector, passed=True, message="PyPi publishing is enabled") | |||
|
|
|||
|
|
|||
| class CheckManifestOnlyConnectorBaseImage(PackagingCheck): | |||
There was a problem hiding this comment.
@natikgadzhi I think we need to add an instance of this class to the ENABLED_CHECKS list at the bottom of this file for it to run?
There was a problem hiding this comment.
BREH you're right.
airbyte-ci/connectors/connectors_qa/src/connectors_qa/checks/metadata.py
Outdated
Show resolved
Hide resolved
airbyte-ci/connectors/connectors_qa/src/connectors_qa/checks/packaging.py
Outdated
Show resolved
Hide resolved
| @@ -63,6 +62,24 @@ def _run(self, connector: Connector) -> CheckResult: | |||
| return self.create_check_result(connector=connector, passed=True, message="PyPi publishing is enabled") | |||
|
|
|||
|
|
|||
| class CheckManifestOnlyConnectorBaseImage(PackagingCheck): | |||
There was a problem hiding this comment.
One other check we could add here is that there are none of the python boilerplate files in this connector directory (e.g. source.py, run.py, etc).
But if we want to add that, that can come in a separate PR. Doesn't need to block this
|
Looks like we need to run |
|
Regenerated the docs, this should get it cleared. |
What
As we're migrating all our connectors to manifest-only format, we must run connector static checks on them. This pull request adds basic support for
manifest-onlyconnectors inconnectors-qa:User Impact
None.