Skip to content

Source Timely: Migrate to manifest-only #43368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 9, 2024
Merged

Source Timely: Migrate to manifest-only #43368

merged 4 commits into from
Aug 9, 2024

Conversation

ChristoGrab
Copy link
Contributor

@ChristoGrab ChristoGrab commented Aug 7, 2024 •
edited
Loading

What

Migrates source Timely to manifest-only format

How

Ran the airbyte-ci command migrate-to-manifest-only.

Review Guide

  1. manifest.yaml: should be at the root level of the folder, list version 4.3.0 and contain an inline spec
  2. metadata.py: should list the correct language tag and point to a recent version of source-declarative-manifest
  3. acceptance-test-config.yml: should correctly point to manifest.yaml for the spec test
  4. readme.md: Should be updated with correct references to the connector (this has historically been a sticking point with our READMEs)
  5. Pretty much everything else should be nuked

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@vercel Vercel
Copy link

vercel bot commented Aug 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2024 8:37pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/timely labels Aug 7, 2024
@ChristoGrab ChristoGrab marked this pull request as ready for review August 7, 2024 18:55
@octavia-squidington-iv octavia-squidington-iv requested a review from a team August 7, 2024 18:56
@natikgadzhi
Copy link
Contributor

@ChristoGrab after #43377 lands, we can rebase this and it will run static checks!

@natikgadzhi natikgadzhi enabled auto-merge (squash) August 9, 2024 20:33
@natikgadzhi natikgadzhi merged commit 37c8ec7 into master Aug 9, 2024
38 checks passed
@natikgadzhi natikgadzhi deleted the christo/timely-manifest-only branch August 9, 2024 20:41
LouisAuneau pushed a commit to LouisAuneau/airbyte that referenced this pull request Aug 13, 2024
@ChristoGrab @natikgadzhi @LouisAuneau
Source Timely: Migrate to manifest-only (airbytehq#43368)
566eeaa 
Co-authored-by: Natik Gadzhi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natikgadzhi natikgadzhi natikgadzhi approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/timely
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristoGrab @natikgadzhi @octavia-squidington-iii