Skip to content

🐛Source Outreach: Fix HTTP 404 during cursor pagination #43350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2024
Merged

🐛Source Outreach: Fix HTTP 404 during cursor pagination #43350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c204efb
fix: outreach cursor pagination
btkcodedev Aug 7, 2024
6018a83
revert page size back to 1000, update docs
btkcodedev Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions airbyte-integrations/connectors/source-outreach/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ poetry install --with dev
**If you are a community contributor**, follow the instructions in the [documentation](https://docs.airbyte.com/integrations/sources/outreach)
to generate the necessary credentials. Then create a file `secrets/config.json` conforming to the `spec` inside `manifest.yaml` file.
Note that any directory named `secrets` is gitignored across the entire Airbyte repo, so there is no danger of accidentally checking in sensitive information.
See `sample_files/sample_config.json` for a sample config file.
See `integration_tests/sample_config.json` for a sample config file.


### Locally running the connector
Expand All @@ -35,11 +35,7 @@ See `sample_files/sample_config.json` for a sample config file.
poetry run source-outreach spec
poetry run source-outreach check --config secrets/config.json
poetry run source-outreach discover --config secrets/config.json
poetry run source-outreach read --config secrets/config.json --catalog sample_files/configured_catalog.json
poetry run source-outreach spec
poetry run source-outreach check --config secrets/config.json
poetry run source-outreach discover --config secrets/config.json
poetry run source-outreach read --config secrets/config.json --catalog sample_files/configured_catalog.json
poetry run source-outreach read --config secrets/config.json --catalog integration_tests/configured_catalog.json
```

### Running tests
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-outreach/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: 3490c201-5d95-4783-b600-eaf07a4c7787
dockerImageTag: 1.0.9
dockerImageTag: 1.0.10
dockerRepository: airbyte/source-outreach
githubIssueLabel: source-outreach
icon: outreach.svg
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-outreach/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ requires = [ "poetry-core>=1.0.0",]
build-backend = "poetry.core.masonry.api"

[tool.poetry]
version = "1.0.9"
version = "1.0.10"
name = "source-outreach"
description = "Source implementation for outreach."
authors = [ "Airbyte <[email protected]>",]
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-outreach/source_outreach/manifest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ definitions:

requester:
type: HttpRequester
url_base: https://api.outreach.io/api/v2
url_base: https://api.outreach.io/api/v2/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly weird — were you able to test this, @btkcodedev? I assumed that the CDK would attempt and add / in automaticallly. But let's see!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @natikgadzhi, I've tested it with both CLI and builder, it was the reason. 🎊

http_method: GET
request_parameters:
count: "false"
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/outreach.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ List of available streams:

| Version | Date | Pull Request | Subject |
| :------ |:-----------| :----- | :------ |
| 1.0.10 | 2024-08-08 | [41107](https://github.com/airbytehq/airbyte/pull/41107) | Fix pagination |
| 1.0.9 | 2024-08-03 | [43128](https://github.com/airbytehq/airbyte/pull/43128) | Update dependencies |
| 1.0.8 | 2024-07-20 | [42254](https://github.com/airbytehq/airbyte/pull/42254) | Update dependencies |
| 1.0.7 | 2024-07-13 | [41786](https://github.com/airbytehq/airbyte/pull/41786) | Update dependencies |
Expand Down
Loading