Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛Source Outreach: Fix HTTP 404 during cursor pagination #43350

Merged
merged 2 commits into from
Aug 8, 2024
Merged

🐛Source Outreach: Fix HTTP 404 during cursor pagination #43350

merged 2 commits into from
Aug 8, 2024

Conversation

btkcodedev
Copy link
Collaborator

What

Closes #41107

How

Fixed the base URL to include closure for identifying the parsing point

User Impact

Bug fix

@btkcodedev btkcodedev self-assigned this Aug 7, 2024
@vercel Vercel
Copy link

vercel bot commented Aug 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 7:40am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/outreach labels Aug 7, 2024
@btkcodedev
Copy link
Collaborator Author

The issue was with base URL without closure ("/"), the declarative default paginator initially sets the cursor to the base URL
Thus if the parser can't find the closure, it resets to initial parsed token with other parameters
Tested & Verified the fix with builder: ✅
image

Tested with terminal: ✅
image

@btkcodedev
Copy link
Collaborator Author

Ready for review and merge

@btkcodedev btkcodedev requested a review from natikgadzhi August 7, 2024 07:53
@btkcodedev
Copy link
Collaborator Author

btkcodedev commented Aug 7, 2024 •
edited
Loading

Ah, yes, just a tiny, super simple fix—only took an eternity to find the time. 🤷‍♂️😂

natikgadzhi
natikgadzhi approved these changes Aug 8, 2024
View reviewed changes
airbyte-integrations/connectors/source-outreach/source_outreach/manifest.yaml
@@ -180,7 +180,7 @@ definitions:

requester:
type: HttpRequester
url_base: https://api.outreach.io/api/v2
url_base: https://api.outreach.io/api/v2/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly weird — were you able to test this, @btkcodedev? I assumed that the CDK would attempt and add / in automaticallly. But let's see!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @natikgadzhi, I've tested it with both CLI and builder, it was the reason. 🎊

@natikgadzhi natikgadzhi merged commit 188fd0c into master Aug 8, 2024
36 checks passed
@natikgadzhi natikgadzhi deleted the btkcodedev/outreachPaginationFix branch August 8, 2024 01:26
LouisAuneau pushed a commit to LouisAuneau/airbyte that referenced this pull request Aug 13, 2024
@btkcodedev @LouisAuneau
🐛Source Outreach: Fix HTTP 404 during cursor pagination (airbytehq#43350
bb15a37 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natikgadzhi natikgadzhi natikgadzhi approved these changes

Assignees

@btkcodedev btkcodedev

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/outreach
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[source-outreach] HTTP 404 during pagination
3 participants
@btkcodedev @natikgadzhi @octavia-squidington-iii