Skip to content

destination-snowflake: bump cdk #43332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

stephane-airbyte
Copy link
Contributor

@stephane-airbyte stephane-airbyte commented Aug 6, 2024

bumping CDK to the latest version. This is necessary to be able to override some test methods to increase timeout.

I disabled largeSync and manyStreamsCompletion because they were timing out. They should be reenabled in the following PRs

I also disabled the tests that were added by the new CDK. They're failing, which points to an existing bug WRT handling of interrupted refreshes

Copy link

vercel bot commented Aug 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2024 6:23pm

Copy link
Contributor Author

stephane-airbyte commented Aug 6, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

@stephane-airbyte stephane-airbyte force-pushed the stephane/destination-snowflake-bump-cdk branch from 93b90f2 to 6e65dda Compare August 6, 2024 17:26
@stephane-airbyte stephane-airbyte changed the base branch from destination-postgres-bump-cdk to stephane/java-cdk-make-TypingedupingTest-aware-of-column-overriding August 6, 2024 17:26
@stephane-airbyte stephane-airbyte force-pushed the stephane/java-cdk-make-TypingedupingTest-aware-of-column-overriding branch from 9669252 to 96624d5 Compare August 6, 2024 17:42
@stephane-airbyte stephane-airbyte force-pushed the stephane/destination-snowflake-bump-cdk branch 2 times, most recently from c9cae0d to c54be45 Compare August 6, 2024 19:41
@stephane-airbyte stephane-airbyte force-pushed the stephane/java-cdk-make-TypingedupingTest-aware-of-column-overriding branch from 96624d5 to d426496 Compare August 6, 2024 20:43
@stephane-airbyte stephane-airbyte force-pushed the stephane/destination-snowflake-bump-cdk branch 4 times, most recently from e575fb7 to 04bd85e Compare August 6, 2024 22:25
@stephane-airbyte stephane-airbyte force-pushed the stephane/java-cdk-make-TypingedupingTest-aware-of-column-overriding branch from d426496 to 0c63d29 Compare August 7, 2024 16:55
@stephane-airbyte stephane-airbyte force-pushed the stephane/destination-snowflake-bump-cdk branch from 04bd85e to 72d8db5 Compare August 7, 2024 16:55
@stephane-airbyte stephane-airbyte force-pushed the stephane/java-cdk-make-TypingedupingTest-aware-of-column-overriding branch from 0c63d29 to 32da45a Compare August 7, 2024 17:10
@stephane-airbyte stephane-airbyte force-pushed the stephane/destination-snowflake-bump-cdk branch from 72d8db5 to 0f66099 Compare August 7, 2024 17:10
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Aug 7, 2024
@stephane-airbyte stephane-airbyte marked this pull request as ready for review August 7, 2024 17:22
@stephane-airbyte stephane-airbyte requested a review from a team as a August 7, 2024 17:22
@stephane-airbyte stephane-airbyte force-pushed the stephane/destination-snowflake-bump-cdk branch from 976fdca to 89a8c06 Compare August 7, 2024 22:14
@octavia-squidington-iii octavia-squidington-iii removed the CDK Connector Development Kit label Aug 7, 2024
@stephane-airbyte stephane-airbyte force-pushed the stephane/destination-snowflake-bump-cdk branch from 89a8c06 to 6980dbd Compare August 7, 2024 23:58
@stephane-airbyte stephane-airbyte force-pushed the stephane/destination-snowflake-bump-cdk branch from 6980dbd to 459901c Compare August 8, 2024 04:03
@stephane-airbyte stephane-airbyte force-pushed the stephane/destination-snowflake-bump-cdk branch from 459901c to 055713e Compare August 8, 2024 20:50
@stephane-airbyte stephane-airbyte force-pushed the stephane/destination-snowflake-bump-cdk branch from 055713e to 10b7a9f Compare August 8, 2024 21:22
@stephane-airbyte stephane-airbyte force-pushed the stephane/destination-snowflake-bump-cdk branch from 10b7a9f to 50f39d6 Compare August 9, 2024 13:34
@stephane-airbyte stephane-airbyte force-pushed the stephane/destination-snowflake-bump-cdk branch from 50f39d6 to 91443b3 Compare August 9, 2024 13:50
@stephane-airbyte stephane-airbyte force-pushed the stephane/destination-snowflake-bump-cdk branch from 91443b3 to c2b1695 Compare August 9, 2024 17:49
Copy link
Contributor Author

stephane-airbyte commented Aug 9, 2024

Merge activity

@stephane-airbyte stephane-airbyte merged commit a324031 into master Aug 9, 2024
36 checks passed
@stephane-airbyte stephane-airbyte deleted the stephane/destination-snowflake-bump-cdk branch August 9, 2024 19:06
LouisAuneau pushed a commit to LouisAuneau/airbyte that referenced this pull request Aug 13, 2024
bumping CDK to the latest version. This is necessary to be able to override some test methods to increase timeout.

I disabled largeSync and manyStreamsCompletion because they were timing out. They should be reenabled in the following PRs

I also disabled the tests that were added by the new CDK. They're failing, which points to an existing bug WRT handling of interrupted refreshes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/snowflake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants