cdk-java move the generationId handling to its own class #43329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
octavia-squidington-iii
added
area/connectors
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @stephane-airbyte and the rest of your teammates on |
stephane-airbyte
force-pushed
the
java-cdk-move-destination-handling
branch
from
0c66ea3 to
f8d50ac
Compare
This was referenced Aug 6, 2024
stephane-airbyte
force-pushed
the
java-cdk-move-destination-handling
branch
from
f8d50ac to
b6a3899
Compare
This was referenced Aug 6, 2024
stephane-airbyte
force-pushed
the
java-cdk-move-destination-handling
branch
from
b6a3899 to
565305b
Compare
stephane-airbyte
requested review from
edgao,
gisripa and
johnny-schmidt
and removed request for
a team
edgao
approved these changes
Aug 7, 2024
|
|
||
| import io.airbyte.cdk.db.jdbc.JdbcDatabase | ||
|
|
||
| interface JdbcGenerationHandler { |
There was a problem hiding this comment.
I think this method should live in DestinationHandler, since we'll need it for all destinations (i.e. not just JDBC)
stephane-airbyte
force-pushed
the
java-cdk-move-destination-handling
branch
from
565305b to
ed95db5
Compare
stephane-airbyte
force-pushed
the
java-cdk-move-destination-handling
branch
from
ed95db5 to
c3916f1
Compare
Merge activity
|
This was referenced Aug 9, 2024
LouisAuneau
pushed a commit
to LouisAuneau/airbyte
that referenced
this pull request
Aug 13, 2024
…3329) This pull request introduces a new interface, `JdbcGenerationHandler`, to handle the retrieval of the `_airbyte_generation_id` for any row in a table. The `getGenerationIdInTable` method has been moved from `SqlOperations` to this new interface. The necessary changes have been made across various classes to integrate this new interface properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new interface,
JdbcGenerationHandler, to handle the retrieval of the_airbyte_generation_idfor any row in a table. ThegetGenerationIdInTablemethod has been moved fromSqlOperationsto this new interface. The necessary changes have been made across various classes to integrate this new interface properly.