Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[destination-convex] Switch json() to text in error handling #42585

Merged
merged 6 commits into from
Aug 5, 2024

Conversation

nipunn1313
Copy link
Contributor

What

Fixes situations where the error is not a JSON.

How

No need to parse as JSON - just print out the result.

Review guide

N/A

User Impact

Users who hit errors get more usable error messages

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Jul 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Aug 5, 2024 5:31pm

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you bump the connector version in the metadata and pyproject file and bump the changelog entry

@marcosmarxm marcosmarxm temporarily deployed to community-ci-auto August 5, 2024 16:40 — with GitHub Actions Inactive
@marcosmarxm marcosmarxm temporarily deployed to community-ci-auto August 5, 2024 16:40 — with GitHub Actions Inactive
@marcosmarxm marcosmarxm changed the title Switch json() to text in convex destination connector error handling [destination-convex] Switch json() to text in error handling Aug 5, 2024
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nipunn1313

@marcosmarxm marcosmarxm merged commit cadb023 into airbytehq:master Aug 5, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/destination/convex
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants